Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS] JSI asBool is not available in RN 0.66 #141

Closed
TimoGlastra opened this issue Mar 11, 2023 · 1 comment · Fixed by #131
Closed

[JS] JSI asBool is not available in RN 0.66 #141

TimoGlastra opened this issue Mar 11, 2023 · 1 comment · Fixed by #131
Assignees
@berendsliedrecht

Comments

@TimoGlastra
Copy link
Member

getBool is available, they may have renamed it.

Check:

  • whether getBool is available in newer versions
  • whether we can directly use the value without unwrapping (value ? 1 : 0)
@TimoGlastra TimoGlastra linked a pull request Mar 11, 2023 that will close this issue
fix(js): several fixes for js wrapper #131
Merged
@berendsliedrecht
Copy link
Contributor

According to software-mansion/react-native-reanimated#3961 it was added in 0.69. So we can just always use getBool and we will be fine.

We could, later on, get rid of the double check whether its a boolean, inside the jsiToValue function as its also checked inside the getBool method with, possibly, a better error message.

@berendsliedrecht berendsliedrecht mentioned this issue Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@berendsliedrecht berendsliedrecht

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(js): several fixes for js wrapper animo/anoncreds-rs
2 participants
@TimoGlastra @berendsliedrecht