Metrics all in one #943
Merged
Metrics all in one #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iceseer
suggested changes
Apr 8, 2021
kamilsa
approved these changes
Apr 8, 2021
kamilsa
approved these changes
Apr 9, 2021
kuvaldini
force-pushed
the
metrics-all-in-one
branch
from
9a0a8da
to
53bc463
Compare
iceseer
approved these changes
Apr 12, 2021
kuvaldini
force-pushed
the
metrics-all-in-one
branch
2 times, most recently
from
773bef6
to
189ece1
Compare
iceseer
reviewed
Apr 22, 2021
lebdron
suggested changes
Apr 26, 2021
kuvaldini
force-pushed
the
metrics-all-in-one
branch
2 times, most recently
from
f072250
to
23ae9e5
Compare
kuvaldini
force-pushed
the
metrics-all-in-one
branch
3 times, most recently
from
d440174
to
582d1ca
Compare
lebdron
reviewed
Apr 28, 2021
kuvaldini
force-pushed
the
metrics-all-in-one
branch
3 times, most recently
from
ea62d16
to
e77d9d9
Compare
lebdron
approved these changes
Apr 30, 2021
kuvaldini
force-pushed
the
metrics-all-in-one
branch
4 times, most recently
from
b4d68b4
to
7737ab3
Compare
kuvaldini
force-pushed
the
metrics-all-in-one
branch
from
7737ab3
to
7bcfc36
Compare
lebdron
reviewed
May 13, 2021
| std::shared_ptr<const shared_model::interface::Block> block_ptr = | ||
| std::move(maybe_block.get()); | ||
| notifier_.get_subscriber().on_next(block_ptr); | ||
| getSubscription()->notify(EventTypes::kOnBlock, block_ptr); |
There was a problem hiding this comment.
I would suggest to parametrize StorageImpl with std::function<void(Block)> so that the class and tests do not depend on subscription engine.
iceseer
approved these changes
May 13, 2021
kuvaldini
force-pushed
the
metrics-all-in-one
branch
2 times, most recently
from
872284f
to
5f48eeb
Compare
kuvaldini
force-pushed
the
metrics-all-in-one
branch
from
7354c5c
to
bfae15d
Compare
…ha#919 hyperledger-iroha#896 hyperledger-iroha#835 Integrate kOnBlock to storage_impl.cpp Closes hyperledger-iroha#837 Add total number of blocks Closes hyperledger-iroha#883 Number of domains Closes hyperledger-iroha#919 Number of signatures in the last block Closes hyperledger-iroha#896 Measure total number of transactions Closes hyperledger-iroha#835 Total nodes/peers updated when kOnBlock Should close hyperledger-iroha#835 no online/connected peers parameter in this commit. Add CMake files to .clang-format-ignore Disable prometheus-cpp logs Extend WSV to countDomains(), countTransactions(), countPeers() -fno-lto to link GCC-10 and clang with civetweb which was built with GCC-9 Tests dependant on ametsuchi are linked against sync_subscription, not async Closes hyperledger-iroha#966 Disable prometheus-cpp self-metrics Signed-off-by: Ivan 'kuvaldini' Kuvaldin <[email protected]>
Signed-off-by: kuvaldini <[email protected]>
Signed-off-by: Ivan 'kuvaldini' Kuvaldin <[email protected]>
kuvaldini
force-pushed
the
metrics-all-in-one
branch
3 times, most recently
from
3643a21
to
bc9abfe
Compare
Signed-off-by: kuvaldini <[email protected]>
kuvaldini
force-pushed
the
metrics-all-in-one
branch
from
bc9abfe
to
693b324
Compare
kuvaldini
added a commit
that referenced
this pull request
Jul 12, 2021
[Metrics] #837 #883 #919 #896 #835 Integrate kOnBlock to storage_impl.cpp Closes #837 Add total number of blocks Closes #883 Number of domains Closes #919 Number of signatures in the last block Closes #896 Measure total number of transactions Closes #835 Total nodes/peers updated when kOnBlock Should close #835 no online/connected peers parameter in this commit. Add CMake files to .clang-format-ignore Disable prometheus-cpp logs Extend WSV to countDomains(), countTransactions(), countPeers() -fno-lto to link GCC-10 and clang with civetweb which was built with GCC-9 Tests dependant on ametsuchi are linked against sync_subscription, not async Closes #966 Disable prometheus-cpp self-metrics Signed-off-by: Ivan 'kuvaldini' Kuvaldin <[email protected]>
This was referenced Jul 12, 2021
Closed
kuvaldini
added a commit
that referenced
this pull request
Jul 14, 2021
[Metrics] #837 #883 #919 #896 #835 Integrate kOnBlock to storage_impl.cpp Closes #837 Add total number of blocks Closes #883 Number of domains Closes #919 Number of signatures in the last block Closes #896 Measure total number of transactions Closes #835 Total nodes/peers updated when kOnBlock Should close #835 no online/connected peers parameter in this commit. Add CMake files to .clang-format-ignore Disable prometheus-cpp logs Extend WSV to countDomains(), countTransactions(), countPeers() -fno-lto to link GCC-10 and clang with civetweb which was built with GCC-9 Tests dependant on ametsuchi are linked against sync_subscription, not async Closes #966 Disable prometheus-cpp self-metrics Signed-off-by: Ivan 'kuvaldini' Kuvaldin <[email protected]>
kuvaldini
added a commit
that referenced
this pull request
Jul 14, 2021
[Metrics] #837 #883 #919 #896 #835 Integrate kOnBlock to storage_impl.cpp Closes #837 Add total number of blocks Closes #883 Number of domains Closes #919 Number of signatures in the last block Closes #896 Measure total number of transactions Closes #835 Total nodes/peers updated when kOnBlock Should close #835 no online/connected peers parameter in this commit. Add CMake files to .clang-format-ignore Disable prometheus-cpp logs Extend WSV to countDomains(), countTransactions(), countPeers() -fno-lto to link GCC-10 and clang with civetweb which was built with GCC-9 Tests dependant on ametsuchi are linked against sync_subscription, not async Closes #966 Disable prometheus-cpp self-metrics Signed-off-by: Ivan 'kuvaldini' Kuvaldin <[email protected]>
kuvaldini
added a commit
that referenced
this pull request
Jul 30, 2021
[Metrics] #837 #883 #919 #896 #835 Integrate kOnBlock to storage_impl.cpp Closes #837 Add total number of blocks Closes #883 Number of domains Closes #919 Number of signatures in the last block Closes #896 Measure total number of transactions Closes #835 Total nodes/peers updated when kOnBlock Should close #835 no online/connected peers parameter in this commit. Add CMake files to .clang-format-ignore Disable prometheus-cpp logs Extend WSV to countDomains(), countTransactions(), countPeers() -fno-lto to link GCC-10 and clang with civetweb which was built with GCC-9 Tests dependant on ametsuchi are linked against sync_subscription, not async Closes #966 Disable prometheus-cpp self-metrics Signed-off-by: Ivan 'kuvaldini' Kuvaldin <[email protected]> Signed-off-by: kuvaldini <[email protected]>
kuvaldini
added a commit
that referenced
this pull request
Jul 30, 2021
[Metrics] #837 #883 #919 #896 #835 Integrate kOnBlock to storage_impl.cpp Closes #837 Add total number of blocks Closes #883 Number of domains Closes #919 Number of signatures in the last block Closes #896 Measure total number of transactions Closes #835 Total nodes/peers updated when kOnBlock Should close #835 no online/connected peers parameter in this commit. Add CMake files to .clang-format-ignore Disable prometheus-cpp logs Extend WSV to countDomains(), countTransactions(), countPeers() -fno-lto to link GCC-10 and clang with civetweb which was built with GCC-9 Tests dependant on ametsuchi are linked against sync_subscription, not async Closes #966 Disable prometheus-cpp self-metrics Signed-off-by: Ivan 'kuvaldini' Kuvaldin <[email protected]> Signed-off-by: kuvaldini <[email protected]>
kuvaldini
added a commit
that referenced
this pull request
Aug 31, 2021
[Metrics] #837 #883 #919 #896 #835 Integrate kOnBlock to storage_impl.cpp Closes #837 Add total number of blocks Closes #883 Number of domains Closes #919 Number of signatures in the last block Closes #896 Measure total number of transactions Closes #835 Total nodes/peers updated when kOnBlock Should close #835 no online/connected peers parameter in this commit. Add CMake files to .clang-format-ignore Disable prometheus-cpp logs Extend WSV to countDomains(), countTransactions(), countPeers() -fno-lto to link GCC-10 and clang with civetweb which was built with GCC-9 Tests dependant on ametsuchi are linked against sync_subscription, not async Closes #966 Disable prometheus-cpp self-metrics Signed-off-by: Ivan 'kuvaldini' Kuvaldin <[email protected]> Signed-off-by: kuvaldini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Metrics] #837 #883 #919 #896 #835
Integrate kOnBlock to storage_impl.cpp
Closes #837 Add total number of blocks
Closes #883 Number of domains
Closes #919 Number of signatures in the last block
Closes #896 Measure total number of transactions
Closes #835 Total nodes/peers updated when kOnBlock
Should close #835 no online/connected peers parameter in this commit.
Add CMake files to .clang-format-ignore
Disable prometheus-cpp logs
Extend WSV to countDomains(), countTransactions(), countPeers()
-fno-lto to link GCC-10 and clang with civetweb which was built with GCC-9
Tests dependant on ametsuchi are linked against sync_subscription, not async