Jenkins jobs on GitHub are marked failed when at least one really fails and others succeed - this dismays

[kuvaldini]

What we see

What should be

GitHub must show succeeded jobs as succeeded, failed as failed. Jobs statuses must correspond.

---

polite ping to @kamilsa @BulatSaif @lebdron

[BulatSaif]

The problem is in this line (https://github.com/hyperledger/iroha/blob/main/Jenkinsfile#L70), it is using the global variable currentBuild.currentResult, any build which runs in parallel(https://github.com/hyperledger/iroha/blob/main/Jenkinsfile#L488) can edit it.
possible fix:

1. create a global map customBuildStatus and store the build results there, and use it to notify git:
   gitNotify ("Jenkins: " + build.name, customBuildStatus[build.name]:?currentBuild.currentResult, 'FAILURE')

or

2. Remove all git Notify and left only one, since the results are the same

[kuvaldini]

And the other similar problem
there are only 2 tests failed, but GitHub reports 7 failed 2 succeeded and 3 started but never finished.

Screenshots were taken from #943 and https://jenkins.soramitsu.co.jp/blue/organizations/jenkins/iroha%2Firoha-hyperledger/detail/PR-943/78/pipeline

[BulatSaif]

3 started but never finished.

This happens then GitHub is down or not available and it didn't receive notification about the finish