-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] #2491: Enum support in FFi #2624
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam H. Smith <[email protected]>
…n Orillion use-cases (hyperledger-iroha#2038) Signed-off-by: Daniil Polyakov <[email protected]>
…er-iroha#2054) Signed-off-by: Sam H. Smith <[email protected]>
…on execution limit (hyperledger-iroha#2051) Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Sam H. Smith <[email protected]>
…losing WebSocket stream (hyperledger-iroha#2095)
Signed-off-by: BAStos525 <[email protected]>
Signed-off-by: BAStos525 <[email protected]>
…only. Signed-off-by: Aleksandr Petrosyan <[email protected]>
Signed-off-by: Aleksandr Petrosyan <[email protected]>
Signed-off-by: Aleksandr Petrosyan <[email protected]>
…hyperledger-iroha#2080) Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Sam H. Smith <[email protected]>
Signed-off-by: Daniil Polyakov <[email protected]>
…Orillion use-case (hyperledger-iroha#2122) Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Aleksandr Petrosyan <[email protected]>
Signed-off-by: Aleksandr Petrosyan <[email protected]>
…os for Identifiable, Eq, Hash, Ord (hyperledger-iroha#2476) * [feature] hyperledger-iroha#1988, hyperledger-iroha#2437: Derive macros for Identifiable, Eq, Hash, Ord Signed-off-by: Ilia Churin <[email protected]> * Refactor `OrdEqHash` into `Identifiable` Signed-off-by: Ilia Churin <[email protected]> * Refactor `IdOrdEqHash` and `Filter` into separate files Signed-off-by: Ilia Churin <[email protected]>
…oint response (hyperledger-iroha#2435) Signed-off-by: Shanin Roman <[email protected]>
…dger-iroha#2516) * [feature] hyperledger-iroha#1891: Validate permission for event triggers Signed-off-by: Ales Tsurko <[email protected]> * [feature] hyperledger-iroha#1891: Update tests Signed-off-by: Ales Tsurko <[email protected]>
Signed-off-by: Shanin Roman <[email protected]>
…ssion validators (hyperledger-iroha#2523) Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: Shunkichi Sato <[email protected]>
Co-authored-by: Ekaterina Mekhnetsova <[email protected]> Signed-off-by: Aleksandr Petrosyan <[email protected]>
Signed-off-by: BAStos525 <[email protected]>
…ng functions (hyperledger-iroha#2538) * [feature] hyperledger-iroha#2490: Implement ffi_export attribute for freestanding functions Signed-off-by: Ales Tsurko <[email protected]> * [feature] hyperledger-iroha#2490: Update gen_ffi_fn to handle free-standing functions Signed-off-by: Ales Tsurko <[email protected]> * [feature] hyperledger-iroha#2490: Update tests Signed-off-by: Ales Tsurko <[email protected]>
Signed-off-by: BAStos525 <[email protected]>
Co-authored-by: Ekaterina Mekhnetsova <[email protected]> Signed-off-by: 6r1d <[email protected]>
Signed-off-by: Aleksandr Petrosyan <[email protected]>
Signed-off-by: Aleksandr Petrosyan <[email protected]>
…ation. Signed-off-by: Aleksandr Petrosyan <[email protected]>
Signed-off-by: Aleksandr Petrosyan <[email protected]>
Signed-off-by: Aleksandr Petrosyan <[email protected]>
Signed-off-by: Aleksandr Petrosyan <[email protected]>
…nts (hyperledger-iroha#2557) Signed-off-by: Marin Veršić <[email protected]>
Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
…roha#2569) Signed-off-by: Daniil Polyakov <[email protected]>
Signed-off-by: BAStos525 [email protected] Co-authored-by: Ekaterina Mekhnetsova <[email protected]> Co-authored-by: 6r1d <[email protected]>
Signed-off-by: BAStos525 <[email protected]>
Signed-off-by: Vladimir Pesterev <[email protected]>
… with definition (hyperledger-iroha#2517) * [refactor] hyperledger-iroha#2052: implement PermissionTokenDefinition Signed-off-by: Artemii Gerasimovich <[email protected]>
…dger-iroha#2590) Signed-off-by: Shanin Roman <[email protected]>
Signed-off-by: Vladimir Pesterev <[email protected]>
closed in favor of #2625 because it has the wrong target branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Add support for converting data-carrying enums to and from FFI types. FFI equivalents for enums are not opaque, rather they are structs generated with FFI representation. Take the following enum as an example:
for
IntoFfi
will generate:for
TryFromReprC
will generate:Issue
Closes #2622
Benefits
Data-carrying enums can be used in FFI functions
Possible Drawbacks
Usage Examples or Tests [optional]
Alternate Designs [optional]