Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 [suggestion] Kagami tool needs crypto algorithm options #2564

Closed
6r1d opened this issue Jul 29, 2022 · 1 comment
Closed

🚀 [suggestion] Kagami tool needs crypto algorithm options #2564

6r1d opened this issue Jul 29, 2022 · 1 comment
Assignees
@6r1d
Labels
Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@6r1d
Copy link
Contributor

6r1d commented Jul 29, 2022 •
edited
Loading

Feature request

Currently, it's a matter of guessing for Kagami's algorithms, but it's possible to add the options to the internal help:

  • ed25519
  • secp256k1
  • bls_normal
  • bls_small

Motivation

It makes Kagami easier to use
@6r1d 6r1d added Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Jul 29, 2022
@6r1d 6r1d self-assigned this Jul 29, 2022
@6r1d
Copy link
Contributor Author

6r1d commented Jul 29, 2022

This is a very small change here, luckily, and it works locally:

/// Algorithm used for generating the key-pair.
/// Options: ed25519, secp256k1, bls_normal, bls_small.

Screenshot_2022-07-29_11-06-51

6r1d added a commit to 6r1d/iroha that referenced this issue Jul 29, 2022
@6r1d
[feature] hyperledger-iroha#2564: Kagami tool algorithm options
a4bb498 
Signed-off-by: 6r1d <[email protected]>
@6r1d 6r1d mentioned this issue Jul 29, 2022
Closed
6r1d added a commit to 6r1d/iroha that referenced this issue Jul 29, 2022
@6r1d
[feature] hyperledger-iroha#2564: Kagami tool algorithm options
839d583 
Signed-off-by: 6r1d <[email protected]>
@6r1d 6r1d mentioned this issue Jul 29, 2022
Merged
6r1d added a commit to 6r1d/iroha that referenced this issue Aug 1, 2022
@6r1d @outoftardis
[feature] hyperledger-iroha#2564: Kagami tool algorithm options
ea36a0c 
Signed-off-by: 6r1d <[email protected]>
Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
6r1d added a commit to 6r1d/iroha that referenced this issue Aug 1, 2022
@6r1d @outoftardis
[feature] hyperledger-iroha#2564: Kagami tool algorithm options
35573dd 
Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: 6r1d <[email protected]>
appetrosyan pushed a commit to 6r1d/iroha that referenced this issue Aug 1, 2022
@6r1d @outoftardis @appetrosyan
[feature] hyperledger-iroha#2564: Kagami tool algorithm options
031aae7 
Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: 6r1d <[email protected]>
appetrosyan pushed a commit that referenced this issue Aug 1, 2022
@6r1d @outoftardis @appetrosyan
[feature] #2564: Kagami tool algorithm options
b8fc0c6 
Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: 6r1d <[email protected]>
BAStos525 pushed a commit to BAStos525/soramitsu-iroha that referenced this issue Aug 3, 2022
@6r1d @outoftardis @BAStos525
[feature] hyperledger-iroha#2564: Kagami tool algorithm options
6516ce9 
Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: 6r1d <[email protected]>
mversic pushed a commit to mversic/iroha that referenced this issue Sep 6, 2022
@6r1d @outoftardis @mversic
[feature] hyperledger-iroha#2564: Kagami tool algorithm options
1e98807 
Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: 6r1d <[email protected]>
mversic pushed a commit to mversic/iroha that referenced this issue Sep 6, 2022
@6r1d @outoftardis @mversic
[feature] hyperledger-iroha#2564: Kagami tool algorithm options
25fb86a 
Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: 6r1d <[email protected]>
mversic pushed a commit to mversic/iroha that referenced this issue Sep 6, 2022
@6r1d @outoftardis @mversic
[feature] hyperledger-iroha#2564: Kagami tool algorithm options
469ccb2 
Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: 6r1d <[email protected]>
mversic pushed a commit to mversic/iroha that referenced this issue Sep 7, 2022
@6r1d @outoftardis @mversic
[feature] hyperledger-iroha#2564: Kagami tool algorithm options
a7c799b 
Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: 6r1d <[email protected]>
mversic pushed a commit to mversic/iroha that referenced this issue Sep 8, 2022
@6r1d @outoftardis @mversic
[feature] hyperledger-iroha#2564: Kagami tool algorithm options
884bd7c 
Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: 6r1d <[email protected]>
mversic pushed a commit to mversic/iroha that referenced this issue Sep 9, 2022
@6r1d @outoftardis @mversic
[feature] hyperledger-iroha#2564: Kagami tool algorithm options
e5b72cf 
Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: 6r1d <[email protected]>
mversic pushed a commit to mversic/iroha that referenced this issue Sep 9, 2022
@6r1d @outoftardis @mversic
[feature] hyperledger-iroha#2564: Kagami tool algorithm options
c675e67 
Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: 6r1d <[email protected]>
mversic pushed a commit to mversic/iroha that referenced this issue Sep 9, 2022
@6r1d @outoftardis @mversic
[feature] hyperledger-iroha#2564: Kagami tool algorithm options
e273ab4 
Co-authored-by: Ekaterina Mekhnetsova <[email protected]>
Signed-off-by: 6r1d <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@6r1d 6r1d

Labels
Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@6r1d @appetrosyan