Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockHeader vs BlockPayload #3895

Closed
mversic opened this issue Sep 18, 2023 · 1 comment
Closed

BlockHeader vs BlockPayload #3895

mversic opened this issue Sep 18, 2023 · 1 comment
Assignees
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST QA-confirmed This bug is reproduced and needs a fix question Further information is requested

Comments

@mversic
Copy link
Contributor

mversic commented Sep 18, 2023

Let's revise which fields go into which of these 2 structures. This is the current state:

    pub struct BlockHeader {
        pub height: u64,
        pub timestamp_ms: u64,
        pub previous_block_hash: Option<HashOf<VersionedSignedBlock>>,
        pub transactions_hash: Option<HashOf<MerkleTree<VersionedSignedTransaction>>>,
        pub commit_topology: Vec<peer::PeerId>,
        pub view_change_index: u64,
        pub consensus_estimation_ms: u64,
    }

    pub struct BlockPayload {
        pub header: BlockHeader,
        pub transactions: Vec<TransactionValue>,
        pub event_recommendations: Vec<Event>,
    }
@mversic mversic added iroha2-dev The re-implementation of a BFT hyperledger in RUST question Further information is requested labels Sep 18, 2023
@mversic
Copy link
Contributor Author

mversic commented Sep 20, 2023

IMO commit_topology should go into BlockPayload, not BlockHeader

mversic added a commit to mversic/iroha that referenced this issue Sep 25, 2023
@mversic mversic self-assigned this Sep 25, 2023
mversic added a commit to mversic/iroha that referenced this issue Sep 25, 2023
mversic added a commit to mversic/iroha that referenced this issue Sep 26, 2023
mversic added a commit to mversic/iroha that referenced this issue Sep 26, 2023
mversic added a commit to mversic/iroha that referenced this issue Sep 26, 2023
mversic added a commit to mversic/iroha that referenced this issue Sep 27, 2023
mversic added a commit that referenced this issue Sep 27, 2023
@timofeevmd timofeevmd self-assigned this Oct 6, 2023
@timofeevmd timofeevmd added the QA-confirmed This bug is reproduced and needs a fix label Oct 6, 2023
6r1d pushed a commit that referenced this issue Oct 17, 2023
6r1d pushed a commit that referenced this issue Oct 17, 2023
mversic added a commit that referenced this issue Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST QA-confirmed This bug is reproduced and needs a fix question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants