-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] #3355: Standardize block API #3884
Merged
mversic
merged 3 commits into
hyperledger-iroha:iroha2-dev
from
mversic:standardize_blocks
Sep 19, 2023
Merged
[feature] #3355: Standardize block API #3884
mversic
merged 3 commits into
hyperledger-iroha:iroha2-dev
from
mversic:standardize_blocks
Sep 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93b0417
to
cdb31cb
Compare
766b4d5
to
d25241d
Compare
d25241d
to
5882262
Compare
92a6c09
to
35310b3
Compare
mversic
commented
Sep 14, 2023
35310b3
to
bf6901d
Compare
mversic
commented
Sep 14, 2023
c93e1f0
to
7ab480a
Compare
Pull Request Test Coverage Report for Build 6223948900
💛 - Coveralls |
DCNick3
reviewed
Sep 14, 2023
7ab480a
to
27f1e6f
Compare
DCNick3
reviewed
Sep 15, 2023
27f1e6f
to
441c59a
Compare
Erigara
reviewed
Sep 15, 2023
c1fc72c
to
1f467a4
Compare
Signed-off-by: Marin Veršić <[email protected]>
1f467a4
to
1ac30dc
Compare
Signed-off-by: Shanin Roman <[email protected]>
DCNick3
previously approved these changes
Sep 18, 2023
Signed-off-by: Marin Veršić <[email protected]>
1475bc2
to
5a72d2e
Compare
DCNick3
approved these changes
Sep 18, 2023
Erigara
approved these changes
Sep 19, 2023
6r1d
pushed a commit
that referenced
this pull request
Oct 17, 2023
Co-authored-by: Shanin Roman <[email protected]> [fix] #3890: Fix validate topology on block sync Signed-off-by: Marin Veršić <[email protected]>
6r1d
pushed a commit
that referenced
this pull request
Oct 17, 2023
Co-authored-by: Shanin Roman <[email protected]> [fix] #3890: Fix validate topology on block sync Signed-off-by: Marin Veršić <[email protected]>
mversic
added a commit
that referenced
this pull request
Oct 17, 2023
Co-authored-by: Shanin Roman <[email protected]> [fix] #3890: Fix validate topology on block sync Signed-off-by: Marin Veršić <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
VersionedCommittedBlock
withVersionedSignedBlock
BlockBuilder
ProofBuilder
Linked issue
Closes #3355 #3424 #3295 #2767
Benefits
Checklist
CONTRIBUTING.md