Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #3355: Standardize block API #3884

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Sep 13, 2023

Description

  • replaced VersionedCommittedBlock with VersionedSignedBlock
  • improved block lifecycle and state transitions
  • introduced BlockBuilder
  • introduced ProofBuilder

Linked issue

Closes #3355 #3424 #3295 #2767

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Sep 13, 2023
@Erigara Erigara self-assigned this Sep 13, 2023
@mversic mversic assigned mversic and Erigara and unassigned Erigara Sep 13, 2023
@DCNick3 DCNick3 self-assigned this Sep 13, 2023
@mversic mversic force-pushed the standardize_blocks branch 10 times, most recently from 766b4d5 to d25241d Compare September 13, 2023 18:38
@mversic mversic marked this pull request as ready for review September 13, 2023 18:42
@mversic mversic force-pushed the standardize_blocks branch 2 times, most recently from 92a6c09 to 35310b3 Compare September 14, 2023 12:52
@mversic mversic force-pushed the standardize_blocks branch 2 times, most recently from c93e1f0 to 7ab480a Compare September 14, 2023 13:57
@coveralls
Copy link

coveralls commented Sep 14, 2023

Pull Request Test Coverage Report for Build 6223948900

  • 707 of 1284 (55.06%) changed or added relevant lines in 43 files are covered.
  • 5625 unchanged lines in 101 files lost coverage.
  • Overall coverage decreased (-1.1%) to 58.327%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cli/src/torii/routing.rs 0 1 0.0%
core/src/smartcontracts/isi/tx.rs 4 5 80.0%
core/src/tx.rs 3 4 75.0%
crypto/src/hash.rs 2 3 66.67%
tools/kagami/src/genesis.rs 0 1 0.0%
tools/kura_inspector/src/main.rs 0 1 0.0%
cli/src/event.rs 0 2 0.0%
cli/src/lib.rs 0 2 0.0%
cli/src/stream.rs 0 2 0.0%
client_cli/src/main.rs 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
cli/src/main.rs 1 0.0%
cli/src/torii/pagination.rs 1 98.9%
config/base/src/runtime_upgrades.rs 1 51.72%
config/src/torii.rs 1 96.67%
core/src/smartcontracts/isi/block.rs 1 87.5%
crypto/src/merkle.rs 1 96.23%
data_model/derive/src/partially_tagged.rs 1 99.67%
data_model/src/domain.rs 1 47.37%
data_model/src/events/execute_trigger.rs 1 30.77%
logger/src/lib.rs 1 95.15%
Totals Coverage Status
Change from base Build 5423219773: -1.1%
Covered Lines: 21419
Relevant Lines: 36722

💛 - Coveralls

DCNick3
DCNick3 previously approved these changes Sep 18, 2023
@mversic mversic merged commit 5db5e32 into hyperledger-iroha:iroha2-dev Sep 19, 2023
@mversic mversic deleted the standardize_blocks branch September 19, 2023 05:58
6r1d pushed a commit that referenced this pull request Oct 17, 2023
Co-authored-by: Shanin Roman <[email protected]>
[fix] #3890: Fix validate topology on block sync

Signed-off-by: Marin Veršić <[email protected]>
6r1d pushed a commit that referenced this pull request Oct 17, 2023
Co-authored-by: Shanin Roman <[email protected]>
[fix] #3890: Fix validate topology on block sync

Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit that referenced this pull request Oct 17, 2023
Co-authored-by: Shanin Roman <[email protected]>
[fix] #3890: Fix validate topology on block sync

Signed-off-by: Marin Veršić <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants