Create filecache at runtime instead of relying on a JSON file that needs to be up to date #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip] [skip ci]
Apply fixes from StyleCI
3 tasks
caendesilva
pushed a commit
that referenced
this pull request
Jul 23, 2022
…omepage-command-when-no-interaction-flag-is-supplied Always output published status for the selected homepage hydephp/develop@21719d4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR created for #243, originally intended to remove the entire filecache system and compare files directly, but realized that the FileCacheService is rather helpful, so changed the scope to create the filecache at runtime instead. See #243 (comment).
This PR will resolve the following issues:
Fix #246
Fix #243