Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instead of having to rely on the filecache.json and ensuring it's up to date, we can just compare files with their vendor counterparts #243

Closed
1 of 3 tasks
caendesilva opened this issue May 2, 2022 · 2 comments · Fixed by #265
Labels
backburner Active issues that are not ready to be fully implemented

Comments

@caendesilva
Copy link
Member

caendesilva commented May 2, 2022

Todos:

caendesilva added a commit that referenced this issue May 2, 2022
caendesilva added a commit that referenced this issue May 2, 2022
@caendesilva caendesilva added the backburner Active issues that are not ready to be fully implemented label May 2, 2022
@caendesilva
Copy link
Member Author

Adding to backburner as it is a rather large change, so deprecating it for the next release, with the removal in a future release.

@caendesilva
Copy link
Member Author

caendesilva commented May 3, 2022

I think the filecache service is pretty useful, and since the filecache array takes around 3.5ms to parse, prettify, and save to file. I think it's acceptable to rework it so that the cache is created on demand instead, especially since it is currently only used for publishing homepages. In the future, if it's used more, it may make sense to store the filecache in memory using a class singleton property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backburner Active issues that are not ready to be fully implemented
Projects
None yet
1 participant