-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create site.php config for site-specific settings #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
===========================================
Coverage 100.00% 100.00%
+ Complexity 817 802 -15
===========================================
Files 103 102 -1
Lines 2094 2022 -72
===========================================
- Hits 2094 2022 -72
Continue to review full report at Codecov.
|
caendesilva
changed the title
Refactor configuration options
Create site.php config for site-specific settings
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This update makes breaking changes to the configuration. You will need to update your configuration to continue using the new changes. Each one has been documented in this changelog entry, which at the end has an upgrade guide.
Changed
hyde.name
tosite.name
hyde.site_url
tosite.site_url
hyde.pretty_urls
tosite.pretty_urls
hyde.generate_sitemap
tosite.generate_sitemap
hyde.language
tosite.language
hyde.output_directory
tosite.output_directory
Removed
$siteName
config variable fromconfig/hyde.php
Upgrade Guide
Site-specific config options have been moved from
config/hyde.php
toconfig/site.php
. The Hyde config is now used to configure behaviour of the site, while the site config is used to customize the look and feel, the presentation, of the site.The following configuration options have been moved. The actual usages remain the same, so you can upgrade by using copying over these options to the new file.
hyde.name
hyde.site_url
hyde.pretty_urls
hyde.generate_sitemap
hyde.language
hyde.output_directory
If you have published and Blade views or written custom code that uses the config options, you may need to update them. You can do this by republishing the Blade views, and/or using search and replace across your code. VSCode has a useful feature to make this a breeze:
CMD/CTRL+Shift+F
.