Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create site.php config? #230

Closed
caendesilva opened this issue Jul 16, 2022 · 1 comment · Fixed by #237
Closed

Create site.php config? #230

caendesilva opened this issue Jul 16, 2022 · 1 comment · Fixed by #237

Comments

@caendesilva
Copy link
Member

This could make config usages more semantic. For example, what does config('hyde.name') mean? Wouldn't it make more sense if it was config('site.name)? The Hyde config could then be scoped to focus more on configuring application behaviour, instead of site presentation.
@caendesilva
Copy link
Member Author

In addition, I would like to implement a YAML config option. This would be an optional feature, and work as a superset over the PHP configs. When the application boots, the YAML config is merged over the others. This, paired with a defined JSON schema would bring a stable location for project configuration settings. The PHP config files would still be used to configure behaviour, while the YAML one is for presentation.

@caendesilva caendesilva linked a pull request Jul 18, 2022 that will close this issue
Create site.php config for site-specific settings #237
Merged
@caendesilva caendesilva mentioned this issue Jul 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create site.php config for site-specific settings hydephp/develop
1 participant
@caendesilva