Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Issue #119 - Entry tap gesture doesn't cancel touches inside… #120

Merged
merged 2 commits into from
Oct 4, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
# Change Log
Any notable changes to this project will be documented in this file.

## 0.8.2

### Bug Fixes:
[Issue #119](https://github.com/huri000/SwiftEntryKit/issues/119) - Entry tap gesture doesn't cancel touches inside the entry view.

## 0.8.1

Apply a necessary fix for Xcode 10 and older than 4.2 Swift version compatibility.
Expand Down
4 changes: 2 additions & 2 deletions Example/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ PODS:
- Nimble (7.3.1)
- Quick (1.3.2)
- QuickLayout (2.1.1)
- SwiftEntryKit (0.8.1):
- SwiftEntryKit (0.8.2):
- QuickLayout (= 2.1.1)

DEPENDENCIES:
Expand All @@ -24,7 +24,7 @@ SPEC CHECKSUMS:
Nimble: 04f732da099ea4d153122aec8c2a88fd0c7219ae
Quick: 2623cb30d7a7f41ca62f684f679586558f483d46
QuickLayout: 9af2b7fd89a6552828f51a5aba28d1bcdb8b340c
SwiftEntryKit: 00a33dff5ddcefd2bd5eac2784778cd4362dd4b6
SwiftEntryKit: 6b3ed18297336ca3aa7d33477d3758cdbf24a6db

PODFILE CHECKSUM: bebf3cef20d24f5c1ea859b0e649573b6222aec0

Expand Down
4 changes: 2 additions & 2 deletions Example/Pods/Local Podspecs/SwiftEntryKit.podspec.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Example/Pods/Manifest.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Example/Pods/Target Support Files/SwiftEntryKit/Info.plist

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,8 @@ The Playground Screen | Top Toast Sample

## Installation

SwiftEntryKit is compatible with Xcode 10 as of release *0.8.1*. Developers who are still using Xcode 9.x.y can install release 0.7.2, or lower versions.
SwiftEntryKit is compatible with Xcode 10 as of release *0.8.1*.
Developers who use Xcode 9.x.y can install release 0.7.2, or any lower version.

### CocoaPods

Expand All @@ -140,7 +141,7 @@ source 'https://github.com/cocoapods/specs.git'
platform :ios, '9.0'
use_frameworks!

pod 'SwiftEntryKit', '0.8.1'
pod 'SwiftEntryKit', '0.8.2'
```

Then, run the following command:
Expand All @@ -163,7 +164,7 @@ $ brew install carthage
To integrate SwiftEntryKit into your Xcode project using Carthage, specify the following in your `Cartfile`:

```ogdl
github "huri000/SwiftEntryKit" == 0.8.1
github "huri000/SwiftEntryKit" == 0.8.2
```

## Usage
Expand Down Expand Up @@ -849,9 +850,8 @@ Yet, it is pretty easy to integrate SwiftEntryKit into an Objective-C project us

## Known Issues

As of release *0.8.1*, SwiftEntryKit is compatible with Xcode 10
As of release *0.8.1*, SwiftEntryKit is compatible with Xcode 10.
Developers who are still using Xcode 9.x.y can install release *0.7.2*.
Other possible workarounds: [Swift 4.2 Support](https://github.com/huri000/SwiftEntryKit/issues/108#issuecomment-425374479)

**Unable to find specification for SwiftEntryKit (=X.Y.Z)** - In case you get this error please review [this thread](https://github.com/huri000/SwiftEntryKit/issues/4).

Expand Down
1 change: 1 addition & 0 deletions Source/Infra/EKContentView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,7 @@ class EKContentView: UIView {
}
let tapGestureRecognizer = UITapGestureRecognizer(target: self, action: #selector(tapGestureRecognized))
tapGestureRecognizer.numberOfTapsRequired = 1
tapGestureRecognizer.cancelsTouchesInView = false
addGestureRecognizer(tapGestureRecognizer)
}

Expand Down
2 changes: 1 addition & 1 deletion SwiftEntryKit.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

Pod::Spec.new do |s|
s.name = 'SwiftEntryKit'
s.version = '0.8.1'
s.version = '0.8.2'
s.summary = 'A simple banner and pop-up displayer for iOS. Written in Swift.'
s.platform = :ios
s.ios.deployment_target = '9.0'
Expand Down