Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Issue #119 - Entry tap gesture doesn't cancel touches inside… #120

Merged
merged 2 commits into from
Oct 4, 2018

Conversation

huri000
Copy link
Owner

@huri000 huri000 commented Oct 4, 2018

… the entry view.

Issue Link 🔗

Issue #119 - Entry tap gesture doesn't cancel touches inside the entry view.

Goals 🥅

Fix the absorbTouches - Let the entry handle the touches.

@codecov
Copy link

codecov bot commented Oct 4, 2018

Codecov Report

Merging #120 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #120      +/-   ##
=========================================
- Coverage    4.21%   4.21%   -0.01%     
=========================================
  Files          56      56              
  Lines        1969    1970       +1     
=========================================
  Hits           83      83              
- Misses       1886    1887       +1
Impacted Files Coverage Δ
Source/Infra/EKContentView.swift 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1980f7e...c994748. Read the comment docs.

@huri000 huri000 merged commit 18e360b into master Oct 4, 2018
@huri000 huri000 deleted the bugfix/tap-gesture-absorbs-touches branch October 4, 2018 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant