fix google#6274: Move delete keyboard shortcut in-progress gesture ch…

…eck to precondition
humera811 · Sep 22, 2023 · d8993f9 · d8993f9
1 parent a04a097
commit d8993f9
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/core/shortcut_items.ts b/core/shortcut_items.ts
@@ -59,7 +59,8 @@ export function registerDelete() {
       return (
         !workspace.options.readOnly &&
         selected != null &&
-        selected.isDeletable()
+        selected.isDeletable() &&
+        !Gesture.inProgress()
       );
     },
     callback(workspace, e) {
@@ -68,10 +69,6 @@ export function registerDelete() {
       // Do this first to prevent an error in the delete code from resulting in
       // data loss.
       e.preventDefault();
-      // Don't delete while dragging.  Jeez.
-      if (Gesture.inProgress()) {
-        return false;
-      }
       (common.getSelected() as BlockSvg).checkAndDelete();
       return true;
     },