Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move delete keyboard shortcut in-progress gesture check to precondition #6274

Closed
BeksOmega opened this issue Jul 15, 2022 · 6 comments · Fixed by #7528
Closed

Move delete keyboard shortcut in-progress gesture check to precondition #6274

BeksOmega opened this issue Jul 15, 2022 · 6 comments · Fixed by #7528
Assignees
@humera811
Labels
ghc-osd Reserved for open source day: https://anitab-org.github.io/open-source-day/ good first issue issue: bug Describes why the code or behaviour is wrong size: small Bugs that can be picked up and completed in 1-3 days
Milestone
Bug Bash Backlog

Comments

@BeksOmega
Copy link
Collaborator

BeksOmega commented Jul 15, 2022 •
edited
Loading

🚧⚠️🚧 This issue is being saved for Grace Hopper Open Source Day. 🚧⚠️🚧 An event we're running to help girls and non-binary technologists make their first contributions to open source! Please see our list of help wanted issues if you'd like to contribute!

Describe the bug

The delete keyboard shortcut currently checks if there is a gesture in progress from within its callback function, and returns early if so. This is what the preconditionFn is meant to do. Other keyboard shortcuts check for in-progress gestures from there.

See the relevant code.

To Fix

  1. Add a check to the precondition function to make sure a gesture is not in progress.
  2. Remove the gesture check from the callback.
@BeksOmega BeksOmega added issue: bug Describes why the code or behaviour is wrong help wanted External contributions actively solicited labels Jul 15, 2022
@BeksOmega BeksOmega added this to the Bug Bash Backlog milestone Jul 15, 2022
@BeksOmega BeksOmega mentioned this issue Jul 15, 2022
Merged
@BeksOmega BeksOmega added the ghc-osd Reserved for open source day: https://anitab-org.github.io/open-source-day/ label Sep 5, 2023
@BeksOmega BeksOmega moved this to Needs Detail in Blockly GHC OSD Sep 5, 2023
@BeksOmega BeksOmega added good first issue size: small Bugs that can be picked up and completed in 1-3 days and removed help wanted External contributions actively solicited labels Sep 5, 2023
@BeksOmega BeksOmega moved this from Needs Detail to Ready for Work in Blockly GHC OSD Sep 6, 2023
@SophieNguyen113
Copy link
Contributor

I would love to work on this issue

@humera811
Copy link
Contributor

@BeksOmega I am interested in working on this

@patelb268
Copy link

I am interested
in these issue

@BeksOmega
Copy link
Collaborator Author

@SophieNguyen113 Go for it!

@humera811 @patelb268 Looks like sophie got here first! If you comment on a different issue I can get you assigned =)

@humera811
Copy link
Contributor

oh okay

@johnnesky
Copy link
Member

I assigned @SophieNguyen113 to #7176 so I assigned @humera811 to this one.

@humera811 humera811 mentioned this issue Sep 22, 2023
Merged
1 task
humera811 added a commit to humera811/blockly that referenced this issue Sep 22, 2023
@humera811
fix google#6274: Move delete keyboard shortcut in-progress gesture ch…
011f375 
…eck to precondition
humera811 added a commit to humera811/blockly that referenced this issue Sep 22, 2023
@humera811
fix google#6274: Move delete keyboard shortcut in-progress gesture ch…
d8993f9 
…eck to precondition
rachel-fenichel added a commit that referenced this issue Sep 22, 2023
@rachel-fenichel
Merge pull request #7528 from humera811/fixes
a488973 
fix: move delete keyboard shortcut in-progress gesture check to precondition #6274
@github-project-automation github-project-automation bot moved this from Ready for Work to Done in Blockly GHC OSD Sep 22, 2023
@BeksOmega BeksOmega moved this from Done Coding to Needs Testing in Blockly GHC OSD Sep 29, 2023
@BeksOmega BeksOmega moved this from Needs Testing to Done Testing in Blockly GHC OSD Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@humera811 humera811

Labels
ghc-osd Reserved for open source day: https://anitab-org.github.io/open-source-day/ good first issue issue: bug Describes why the code or behaviour is wrong size: small Bugs that can be picked up and completed in 1-3 days
Projects
No open projects
Blockly GHC OSD
Status: Done Testing
Milestone
Bug Bash Backlog
Development

Successfully merging a pull request may close this issue.

fix: move delete keyboard shortcut in-progress gesture check to precondition #6274 humera811/blockly
5 participants
@humera811 @BeksOmega @johnnesky @patelb268 @SophieNguyen113