Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing version from docker compose file #690

Merged
merged 2 commits into from
May 24, 2024
Merged

Removing version from docker compose file #690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5558cb
Removing version from docker compose file
filter182 May 2, 2024
2af83b8
Adding proxy.yml to the same pull
filter182 May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docker/proxy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
version: '3.5'
services:
proxy:
networks:
Expand Down
2 changes: 1 addition & 1 deletion inc/composer/class-docker-compose-generator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,7 +813,7 @@ public function get_array() : array {

// Default compose configuration.
$config = [
'version' => '2.3',
// 'version' => '2.5',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this comment here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes the warning message WARN[0000] /home/jcmarin/composetest/compose.yml: version is obsolete when running the composer server command, this was deprecated as per this article.

'services' => $services,
'networks' => [
'default' => null,
Expand Down