Removing version from docker compose file #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kovshenin
reviewed
Jun 4, 2024
| @@ -813,7 +813,7 @@ public function get_array() : array { | |||
|
|
|||
| // Default compose configuration. | |||
| $config = [ | |||
| 'version' => '2.3', | |||
| // 'version' => '2.5', | |||
There was a problem hiding this comment.
What's the purpose of this comment here?
There was a problem hiding this comment.
This removes the warning message WARN[0000] /home/jcmarin/composetest/compose.yml: version is obsolete when running the composer server command, this was deprecated as per this article.
This was referenced Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal discussion with Konstantin, during a testing on local server we found some warning about the
versionis now obsolete, according to the Docker documentation the legacy versions 2.x and 3.x of the Compose file format were merge in the Compose Specification, it was implemented in version 1.27.0 (Compose V2) of the Docker Compose CLI as per this article.This PR fixes the warning shown when running the command
composer serverthat is specified in line 816'version' => '2.3',, commenting that line and removing the version directly from proxy.yml fixed the warning during the local server start/creation.