Support for ARM64 #343

ntwb · 2021-09-19T15:07:01Z

Follow up to #252

This PR was created using Altis v8 with local-server release candidate 8.1.0-rc here

Notes:

All images are native ARM64, no containers run under emulation
All images except for Mailhog are using the original Docker base image
Minio ~12 months ago bumped MC to v10 when multi-arch images began being built, hence the v10 config bump
I've used latest for Docker images here for simplicity, pinning to specific releases would be required for release
I'm using mysql/mysql-server:8.0, rather than MariaDB, solely because I have a client project where I'm using this daily, I think the suggestion has been to prefer MariaDB over MySQL v8?

Testing

From the dashboard -> tools menu e.g. https://subdomain.altis.dev/wp-admin/tools.php

❌ S3 Browser - https://s3-subdomain.altis.dev/minio
- The following warning is displayed when opening the above URL:
  - NoSuchKeyThe specified key does not exist.minios3-subdomain/minious-east-xxxxxxxxxxx
✅ Kibana - https://subdomain.altis.dev/kibana/
- Works as expected and opens Kibana at https://subdomain.altis.dev/kibana/app/home#/
✅ Mailhog - https://subdomain.altis.dev/mailhog/
- Works as expected and opens Mailhog at https://subdomain.altis.dev/mailhog

joehoyle · 2021-09-20T13:12:08Z

I'm using mysql/mysql-server:8.0, rather than MariaDB, solely because I have a client project where I'm using this daily, I think the suggestion has been to prefer MariaDB over MySQL v8?

I think this is due to compatibility, the assumption being that Maria would be closer to MySQL 5.7 in terms of compat. We will need to switch Altis Cloud to MySQL 8 at some point . I don't believe AWS Aurora MySQL supports 8 yet, so I don't think we'd be switching for some time though.

roborourke · 2021-09-20T16:26:55Z

That minio error is kinda telling: exist.minios3-subdomain/minious-east-xxxxxxxxxxx

I think it'll work with a slash on the end eg. https://s3-subdomain.altis.dev/minio/ - if the admin tools menu link is missing that then we should add it. Maybe it's some change in minio 10. Let me know if that sorts it anyway. Maybe some other Minio admin related stuff has changed.

roborourke · 2021-09-21T09:49:51Z

I'll go through an make tagged releases for anything referencing latest here unless they already exist.

The MySQL 8 issue seems to be the major hurdle here. Local databases will need to be recreated to use it iirc.

We could try this image in the interim https://hub.docker.com/r/biarms/mysql - not official but has a lot of pulls / usage.

roborourke

I think this should cover it

inc/composer/class-docker-compose-generator.php

ntwb · 2021-09-21T23:00:23Z

That minio error is kinda telling: exist.minios3-subdomain/minious-east-xxxxxxxxxxx

I think it'll work with a slash on the end eg. https://s3-subdomain.altis.dev/minio/ - if the admin tools menu link is missing that then we should add it. Maybe it's some change in minio 10. Let me know if that sorts it anyway. Maybe some other Minio admin related stuff has changed.

It did not, same error though there's now a / between minio and the AWS region:

NoSuchKeyThe specified key does not exist.minio/s3-subdomain/minio/us-east-xxxxxxxxxxx

And correct, the tools menu item doesn't include the trailing slash...

ntwb · 2021-09-21T23:04:04Z

Thanks, I'll go through and update images in the coming days, I should be able to dump my database and try with that MySQL v5.7 build also.

roborourke · 2021-09-22T08:44:27Z

It did not, same error though there's now a / between minio and the AWS region:

Cheers for confirming, will need to dig into the config then. There's a bit of faffing around to get the URLs to play nicely.

rmccue · 2021-09-22T09:48:15Z

n.b. I made some slight improvements to the Minio/AWS SDK configuration in #341 that might be worth looking at here; in particular, changing the Minio hostname and the SDK config to avoid dynamically building hostnames.

joehoyle · 2021-09-27T20:21:42Z

I noticed in https://github.com/humanmade/altis-local-server/blob/arm64-support-stephen/inc/composer/class-command.php#L706 too we reference a version of minio, does that need to be updated?

inc/composer/class-docker-compose-generator.php

joehoyle · 2021-09-28T20:50:04Z

Ok I can confirm I'm working, with all ARM containers (I did some manual fix-ups to the above missing images):

I wrote a quick bash script to verify (all dev_ containers for example).

docker ps | grep dev_ | awk '{print $1}' | xargs -I _ docker inspect _ -f '{{.Config.Image}}' | xargs -I z docker image inspect z -f '{{.Architecture}}'
arm64
arm64
arm64
arm64
arm64
arm64
arm64
arm64
arm64
arm64
arm64
arm64
arm64
arm64
amd64

The amd64 one at the end is 565b39f66056 mutagenio/sidecar:latest "/usr/bin/mutagen-si…" 35 minutes ago Up 35 minutes dev_mutagen_1 I'm not actually sure why I'm getting that though, because I didn't think I have mutagen on. However, do we need to look for that.

roborourke · 2021-09-29T08:08:07Z

Ah ok, it won't be used unless you pass the --mutagen flag.

What version of the mutagen beta do you have installed? It looks like multiarch builds should be available with the 0.12.0 beta https://hub.docker.com/r/mutagenio/sidecar/tags

roborourke · 2021-09-29T09:38:15Z

For what it's worth mutagen is still an experimental feature so I don't see that as a blocker for this.

ntwb · 2021-09-29T10:54:46Z

Yeah, I've been using mutagen locally, unsure how to fully test, but nothing seems to break, latest arm64 links and instructions are in the nightly docs too

https://docs.altis-dxp.com/local-server/mutagen-file-sharing/

ntwb · 2021-09-29T11:01:29Z

I noticed in arm64-support-stephen/inc/composer/class-command.php#L706 too we reference a version of minio, does that need to be updated?

I suspect so, I missed updating this, once minio was bumped to 10 here these builds began working, on 9 the container constantly crashed https://github.com/humanmade/altis-local-server/pull/343/files#diff-9c62893c068f43a8f846f52604e52ced6c8278a8cd2216ac4060e2f052dbf9edR2

joehoyle · 2021-09-29T14:49:16Z

inc/composer/class-docker-compose-generator.php

@@ -91,7 +91,7 @@ protected function get_php_reusable() : array {
 					'condition' => 'service_started',
 				],
 			],
-			'image' => 'humanmade/altis-local-server-php:4.0.0-dev',
+			'image' => 'humanmade/altis-local-server-php:4.2.0',


@roborourke -dev IIRC is the dev container, not a "dev version" that has xdebug intsalled: https://github.com/humanmade/docker-wordpress-php/blob/master/Dockerfile-dev. Did we stop using -dev just for the tag (and it's built from -dev?)-- sorry I can't remember but wanted to check, as I think it might have even been me who made that change!

Ah gotcha, yeah so the GitHub workflow uses the Dockerfile-dev file to build. It wasn't a dev container - it was always just used to reference the version that had Xdebug installed. I think that's fine personally as Xdebug 3 can be present and have minimal impact. Plus we don't use the builds on Docker hub on our infrastructure.

I didn't make that particular change, I just didn't notice it earlier - I thought we still had the regular tag and tag + -dev with Xdebug being built and pushed up.

The -dev suffix was previously how we toggled between a container with Xdebug and one without, but we use the XDEBUG_MODE env var to switch it on or off now.

Container versions are all correct now, confirmed working

ARM64 Support - Stephen

02a5952

ntwb mentioned this pull request Sep 19, 2021

Support for Arm64 #252

Closed

roborourke requested changes Sep 21, 2021

View reviewed changes

roborourke changed the title ~~Support for ARM64 - Stephen~~ Support for ARM64 Sep 22, 2021

Use newer minio container for minio client command

d0a266e

roborourke marked this pull request as ready for review September 28, 2021 13:40

Use pinned container versions

de974c3

joehoyle previously requested changes Sep 28, 2021

View reviewed changes

inc/composer/class-docker-compose-generator.php Outdated Show resolved Hide resolved

inc/composer/class-docker-compose-generator.php Outdated Show resolved Hide resolved

Fix tachyon and PHP tags

19c15fc

roborourke requested a review from joehoyle September 29, 2021 08:08

roborourke approved these changes Sep 29, 2021

View reviewed changes

joehoyle reviewed Sep 29, 2021

View reviewed changes

roborourke merged commit 2a9cf9f into master Sep 29, 2021

roborourke deleted the arm64-support-stephen branch September 29, 2021 15:16

roborourke mentioned this pull request Sep 29, 2021

Support ARM64 architectures (Apple Silicon) for Docker containers #347

Closed

roborourke added the backport v8-branch-rc label Oct 6, 2021

hm-backport bot mentioned this pull request Oct 6, 2021

[Backport v8-branch-rc] Support for ARM64 #360

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for ARM64 #343

Support for ARM64 #343

ntwb commented Sep 19, 2021 •

edited

Loading

joehoyle commented Sep 20, 2021

roborourke commented Sep 20, 2021

roborourke commented Sep 21, 2021

roborourke left a comment

ntwb commented Sep 21, 2021

ntwb commented Sep 21, 2021

roborourke commented Sep 22, 2021

rmccue commented Sep 22, 2021

joehoyle commented Sep 27, 2021

joehoyle commented Sep 28, 2021

roborourke commented Sep 29, 2021

roborourke commented Sep 29, 2021

ntwb commented Sep 29, 2021

ntwb commented Sep 29, 2021

joehoyle Sep 29, 2021

roborourke Sep 29, 2021

roborourke Sep 29, 2021 •

edited

Loading

Support for ARM64 #343

Support for ARM64 #343

Conversation

ntwb commented Sep 19, 2021 • edited Loading

Testing

joehoyle commented Sep 20, 2021

roborourke commented Sep 20, 2021

roborourke commented Sep 21, 2021

roborourke left a comment

Choose a reason for hiding this comment

ntwb commented Sep 21, 2021

ntwb commented Sep 21, 2021

roborourke commented Sep 22, 2021

rmccue commented Sep 22, 2021

joehoyle commented Sep 27, 2021

joehoyle commented Sep 28, 2021

roborourke commented Sep 29, 2021

roborourke commented Sep 29, 2021

ntwb commented Sep 29, 2021

ntwb commented Sep 29, 2021

joehoyle Sep 29, 2021

Choose a reason for hiding this comment

roborourke Sep 29, 2021

Choose a reason for hiding this comment

roborourke Sep 29, 2021 • edited Loading

Choose a reason for hiding this comment

ntwb commented Sep 19, 2021 •

edited

Loading

roborourke Sep 29, 2021 •

edited

Loading