Support Codespaces

[rmccue]

Early draft of just getting things working. Built on #40.

One of the bigger changes here is changing how Minio works. Rather than using the automatic bucket domain building, this changes it to be more in line with the other tools with a static domain. Additionally, it disables the TLS validation, since Minio has the wrong certificate (slash, self-signed? dunno) for these purposes. (nb, I haven’t updated this for the latest changes which added the Traefik routing; that work probably wants to go back into #40 too)

With these changes, it’s zero-configuration to work on Codespaces. Just start a Codespace with an Altis project, and composer install && composer server start, and the linked domain will just work. That said, you can also use a simplified dev container for a bit speedier setup.

This also works if you use Codespaces with VS Code desktop, but this instead uses localhost as the host, which is a bit annoying. Needs to be disabled somehow? I think there’s a VS Code setting for it idk

Needs more testing, and I am probably bad at code, so there might be cleaner ways to do some of the stuff. Also needs docs (and maybe we get a blog post up for it?)

(I’ve set the humanmade org to have $100 worth of credits, since we’re now out of the free period for Codespaces.)

[roborourke]

Not super into the secure switch here but I guess browser APIs that require https should work on localhost. If that's needed for zero config set up then all good.

[rmccue]

Oh, the secure bit is from @joehoyle's original PR I think?

[joehoyle]

Not super into the secure switch here but I guess browser APIs that require https should work on localhost. If that's needed for zero config set up then all good.

Yeah that was from my PR, it was basically a way to support other domains etc until we get a way to generate the SSL certs etc.

[roborourke]

It feels like a good candidate for packaging up the functionality, e.g. in a WP plugin using set_url_scheme() would have the desired effect. Fewer ternaries cluttering up the place.

@rmccue can you test this with the recent changes to the Minio frontends?

[joehoyle]

@roborourke im not sure I follow-- how would a wp plugin change all the local server configuration to run services as http rather than https?

[roborourke]

Sorry I just meant the set_url_scheme() function provided by WordPress could be useful here.

[joehoyle]

@rmccue anything a blocker here now? is there hope to get this in v9?

[roborourke]

Linter checks are failing still, and I think it needs to rebased on master or have master merged into it.

[roborourke]

Couple of tweaks to do for now, will need some documentation once the functionality is all confirmed.

I believe we need Tachyon to optionally support non-verified S3 requests as well as that's currently broken in Codespaces.

[roborourke]

I don't really understand the purpose of this config option.

[rmccue]

We detect the CODESPACES environment variable and override a bunch of stuff if it's set. If you didn't want those overrides applied, this allows this to turn those off.

[roborourke]

I get that much but why wouldn't you want those overrides?

[rmccue]

If you wanted to set up different domains for testing purposes; without this, there's no way to avoid codespaces overriding the settings, so you wouldn't be able to test other domains/etc.

[shadyvb]

Refreshed rebased and extended at #466 , addressed feedback, closing this one down, but keeping the branch for comparison and referencing.

[shadyvb]

Reopening after separating concerns between SSL and Codespaces support.

[shadyvb]

Couple of remaining dependencies:

• Need to add the dev container so we can set PHP version to 8
• Need to fix the PHP 8 dependency issues in dev-tools/wp-browser

[roborourke]

Not tested myself yet but looks good - just one comment stating a todo to check on, guessing it just needs removing.

Good stuff!