Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple local avatars #111

Closed
wants to merge 9 commits into from
Closed

Conversation

pdewouters
Copy link
Contributor

@pdewouters pdewouters commented Oct 11, 2019

See #7

Assuming the package will be names 10up/simple-local-avatars when published
Will need an upstream fix - see humanmade/simple-local-avatars#1

@pdewouters
Copy link
Contributor Author

I've changed the required version to 2.2 because that seems to be the one that we'll need with the fix I proposed.

@roborourke roborourke changed the title Add simple local avatars WIP: Add simple local avatars Oct 21, 2019
@roborourke
Copy link
Contributor

NOTE: We need to wait until 2.2.0 is released before this can be merged.

@joehoyle joehoyle mentioned this pull request Mar 27, 2020
4 tasks
@rmccue
Copy link
Member

rmccue commented Jun 12, 2020

2.2 is still not released.

@roborourke roborourke added this to the 5.0 milestone Jun 16, 2020
@tareiking
Copy link

2.2 still not released, however a new issue tracking release requirements is opened on 10up/simple-local-avatars#51

@joehoyle
Copy link
Member

2.2 is now released, so I think this is good to be merged?

@pdewouters
Copy link
Contributor Author

I don't see a 2.2?

@joehoyle
Copy link
Member

Ah sorry I misread the comment from @adamsilverstein, it seems only the branch has been created https://github.com/10up/simple-local-avatars/tree/release/2.2.0

@rmccue rmccue removed this from the 5.0 milestone Sep 2, 2020
@jeffpaul
Copy link

Correct, we're nearing 2.2 release and are doing some final review on adding test coverage to increase our confidence in the release. If you have opinions on 10up/simple-local-avatars#59 then by all means please comment, otherwise we're working to finalize there and get the release out.

@roborourke
Copy link
Contributor

Thanks for the update @jeffpaul 👍 Will check it out

@jeffpaul
Copy link

@roborourke FYI that we're targeting Monday for the 2.2.0 release, apologies for the delay

@jeffpaul
Copy link

@roborourke note that the 2.2.0 release is now live

@roborourke
Copy link
Contributor

@jeffpaul amazing, thanks for letting me know 🥇

@roborourke roborourke changed the title WIP: Add simple local avatars Add simple local avatars Nov 30, 2020
@jazzsequence
Copy link
Contributor

closing in favor of #392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants