Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Unit test #59

Merged
merged 7 commits into from
Sep 30, 2020
Merged

Add: Unit test #59

merged 7 commits into from
Sep 30, 2020

Conversation

dinhtungdu
Copy link
Contributor

This PR:

  • splits the main class into its own file.
  • adds unit tests for this project using WP_Mock.
  • sets up GitHub Actions workflow to run unit tests.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Fixes #1

@dinhtungdu dinhtungdu self-assigned this Sep 14, 2020
@dinhtungdu dinhtungdu marked this pull request as ready for review September 14, 2020 09:49
@dinhtungdu dinhtungdu requested a review from helen September 14, 2020 09:49
@jeffpaul jeffpaul added this to the 2.2.0 milestone Sep 14, 2020
@jeffpaul jeffpaul mentioned this pull request Sep 16, 2020
Closed
helen
helen previously approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@helen helen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything here looks fine to me (just one typo I noted), let's do this.

.github/workflows/test.yml Outdated Show resolved Hide resolved
@jeffpaul @helen
Update .github/workflows/test.yml
8bcb775 
Co-authored-by: Helen Hou-Sandi <[email protected]>
@jeffpaul jeffpaul merged commit 3b6d52f into develop Sep 30, 2020
@jeffpaul jeffpaul deleted the add/unit-tests branch October 28, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helen helen helen left review comments

Assignees

@dinhtungdu dinhtungdu

Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

Add unit tests
3 participants
@dinhtungdu @helen @jeffpaul