Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manual head_dim for mixtral model #34281

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

wavy-jung
Copy link
Contributor

What does this PR do?

  • manual head_dim setting for mixtral model
  • same as llama and mistral implementation
  • worked well when I tested with sparse upcycled llama model

Fixes #34261

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ArthurZucker @gante

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Sounds good, could you make sure to fix the cis and rebase? 🤗

@wavy-jung
Copy link
Contributor Author

wavy-jung commented Oct 23, 2024

@ArthurZucker I literally have no idea why the CI check fails at glm modeling code. I did not make any changes to the glm models. Can you help me with this or can you give me a brief guideline?

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were fixed on main! You can now rebase and should be good!

@ArthurZucker
Copy link
Collaborator

make fix-copies might be needed as mistral is copied here and there

@wavy-jung
Copy link
Contributor Author

@ArthurZucker I did fix-copies & rebase. It seems all the checks are passed.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🤗

@ArthurZucker ArthurZucker merged commit 8755dd2 into huggingface:main Oct 29, 2024
17 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

2015aroras pushed a commit to 2015aroras/transformers that referenced this pull request Nov 15, 2024
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
BernardZach pushed a commit to innovationcore/transformers that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mixtral manual head_dim
3 participants