-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manual head_dim
for mixtral
model
#34281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Sounds good, could you make sure to fix the cis and rebase? 🤗
0ba1484
to
cc09202
Compare
@ArthurZucker I literally have no idea why the CI check fails at glm modeling code. I did not make any changes to the glm models. Can you help me with this or can you give me a brief guideline? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were fixed on main! You can now rebase and should be good!
|
cc09202
to
486a932
Compare
@ArthurZucker I did |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🤗
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
What does this PR do?
head_dim
setting formixtral
modelllama
andmistral
implementationFixes #34261
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker @gante