Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixtral manual head_dim #34261

Closed
wavy-jung opened this issue Oct 19, 2024 · 0 comments · Fixed by #34281
Closed

Mixtral manual head_dim #34261

wavy-jung opened this issue Oct 19, 2024 · 0 comments · Fixed by #34281
Labels
Feature request Request for a new feature Usage General questions about the library

Comments

@wavy-jung
Copy link
Contributor

Feature request

self.head_dim = self.hidden_size // self.num_heads

head_dim in mixtral model is forced to have the value of hidden_size // num_heads. However, this it not the case in llama model or even in mistral model. So, it will be a good minor feature to support manual head_dim setting for mixtral model as well!

Motivation

  • manual head_dim in llama or mistral model

Your contribution

PR

@wavy-jung wavy-jung added the Feature request Request for a new feature label Oct 19, 2024
@LysandreJik LysandreJik added the Usage General questions about the library label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Request for a new feature Usage General questions about the library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants