Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix canonical model --model_type in examples #30480

Merged

Conversation

amyeroberts
Copy link
Collaborator

What does this PR do?

#29001 Updated references to canonical models. Some of the gpt2 replacements gpt2 -> openai-community/gpt2 should be reverted back, as they refer to the model type, rather than checkpoint

@amyeroberts amyeroberts changed the title Fix --model_type in examples Fix canonical model --model_type in examples Apr 25, 2024
@amyeroberts amyeroberts requested a review from LysandreJik April 25, 2024 10:57
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@amyeroberts amyeroberts mentioned this pull request Apr 25, 2024
4 tasks
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops indeed, nice catch!

@amyeroberts amyeroberts merged commit bbaa8ce into huggingface:main May 1, 2024
8 checks passed
@amyeroberts amyeroberts deleted the fix-references-model-type branch May 1, 2024 14:47
itazap pushed a commit that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants