Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Whisper] Add sequential longform decoding #27492
[Whisper] Add sequential longform decoding #27492
Changes from 22 commits
51d2a53
b0c387d
e7cb31b
0c3e8c5
6e5ce42
ba318f7
c47c316
a9ce5b4
2b0dcf6
8b2281f
0afe526
d2d16b4
68e8226
ee43be4
1030f22
04477e7
87b5d8d
a9cf2bb
5f3ff78
6c942be
1c1d1e6
74967ee
0e95291
311995d
aeee0f2
c8507c7
0593495
4382898
708be99
0dfead2
79c39d8
62ccd52
a5755d9
a75ea30
cc4c19c
0878ac6
889eebb
c1c2042
cc1f87c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logit processor was incorrectly added before. Also note that since we never had support for "sequential" or "timestamp"-chunked transcription before, we didn't really use the class before. It was only used when single 30s chunks were supposed to predict timestamps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if I am not understanding the statement 😅 No it was used for
chunked
processing because the merging algorithm heavily relies on timestamps, and also produces timestamps. See this line which always add the processor.Placing a breakpoint in the call of this class with this:
(this is for me "timestamp" chunk transcription.