-
Notifications
You must be signed in to change notification settings - Fork 27.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Whisper] Add sequential longform decoding #27492
Merged
Merged
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
51d2a53
[Whisper] Add seq gen
patrickvonplaten b0c387d
[Whisper] Add seq gen
patrickvonplaten e7cb31b
more debug
patrickvonplaten 0c3e8c5
Fix whisper logit processor
patrickvonplaten 6e5ce42
Improve whisper code further
patrickvonplaten ba318f7
Fix more
patrickvonplaten c47c316
Merge branch 'main' of https://github.com/huggingface/transformers in…
patrickvonplaten a9ce5b4
Merge branch 'main' of https://github.com/huggingface/transformers in…
patrickvonplaten 2b0dcf6
more debug
patrickvonplaten 8b2281f
more debug
patrickvonplaten 0afe526
Improve further
patrickvonplaten d2d16b4
Add tests
patrickvonplaten 68e8226
Prep for batch size > 1
patrickvonplaten ee43be4
Get batch_size>1 working
patrickvonplaten 1030f22
Correct more
patrickvonplaten 04477e7
Add extensive tests
patrickvonplaten 87b5d8d
more debug
patrickvonplaten a9cf2bb
more debug
patrickvonplaten 5f3ff78
more debug
patrickvonplaten 6c942be
Merge branch 'main' of https://github.com/huggingface/transformers in…
patrickvonplaten 1c1d1e6
add more tests
patrickvonplaten 74967ee
more debug
patrickvonplaten 0e95291
Apply suggestions from code review
patrickvonplaten 311995d
more debug
patrickvonplaten aeee0f2
add comments to explain the code better
patrickvonplaten c8507c7
add comments to explain the code better
patrickvonplaten 0593495
add comments to explain the code better
patrickvonplaten 4382898
Add more examples
patrickvonplaten 708be99
add comments to explain the code better
patrickvonplaten 0dfead2
fix more
patrickvonplaten 79c39d8
Merge branch 'add_whisper_seq_gen' of https://github.com/huggingface/…
patrickvonplaten 62ccd52
add comments to explain the code better
patrickvonplaten a5755d9
Merge branch 'add_whisper_seq_gen' of https://github.com/huggingface/…
patrickvonplaten a75ea30
add comments to explain the code better
patrickvonplaten cc4c19c
correct
patrickvonplaten 0878ac6
correct
patrickvonplaten 889eebb
finalize
patrickvonplaten c1c2042
Apply suggestions from code review
patrickvonplaten cc1f87c
Apply suggestions from code review
patrickvonplaten File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logit processor was incorrectly added before. Also note that since we never had support for "sequential" or "timestamp"-chunked transcription before, we didn't really use the class before. It was only used when single 30s chunks were supposed to predict timestamps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if I am not understanding the statement 😅 No it was used for
chunked
processing because the merging algorithm heavily relies on timestamps, and also produces timestamps. See this line which always add the processor.Placing a breakpoint in the call of this class with this:
(this is for me "timestamp" chunk transcription.