Revert "Only add files with modification outside doc blocks" #23371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
force-pushed
the
revert-23327-only_modified_doc_block
branch
from
7621c8f to
a480dca
Compare
amyeroberts
approved these changes
May 15, 2023
There was a problem hiding this comment.
Thanks for fixing!
Apologies for not catching in the review either. In the nightly CI, have we run all of the doctests - or do we expect there to be any untested pieces of code between the merge of #23327 and this PR?
On daily doctest CI, everything is tested :-) - there is no filtration, it just check all files in |
|
The documentation is not available anymore as the PR was closed or merged. |
sheonhan
pushed a commit
to sheonhan/transformers
that referenced
this pull request
Jun 1, 2023
…face#23371) fix Co-authored-by: ydshieh <[email protected]>
gojiteji
pushed a commit
to gojiteji/transformers
that referenced
this pull request
Jun 5, 2023
…face#23371) fix Co-authored-by: ydshieh <[email protected]>
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
…face#23371) fix Co-authored-by: ydshieh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #23327.
I apologize, but I read Sylvain's messge too quickly and got it completely wrong.
That merged PR did the converse instead: it adds a test file if only docstring (instead of only code) are modified.
I will need to create sth like
diff_is_code_only.