Only add files with modification outside doc blocks #23327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
ydshieh
commented
May 12, 2023
| @@ -151,7 +151,7 @@ | |||
| "psutil", | |||
| "pyyaml>=5.1", | |||
| "pydantic", | |||
| "pytest", | |||
There was a problem hiding this comment.
min. version to make the following work (used in src/transformers/testing_utils.py for the doctest in PRs)
from _pytest.doctest import Module,
ydshieh
commented
May 12, 2023
Comment on lines
+230
to
+244
| # Now for modified files | ||
| elif ( | ||
| diff_obj.change_type in ["M", "R"] | ||
| and diff_obj.b_path.endswith(".py") | ||
| or diff_obj.b_path.endswith(".mdx") | ||
| ): | ||
| # In case of renames, we'll look at the tests using both the old and new name. | ||
| if diff_obj.a_path != diff_obj.b_path: | ||
| code_diff.extend([diff_obj.a_path, diff_obj.b_path]) | ||
| else: | ||
| # Otherwise, we check modifications are in code and not docstrings. | ||
| if diff_is_docstring_only(repo, commit, diff_obj.b_path): | ||
| print(f"Ignoring diff in {diff_obj.b_path} as it only concerns docstrings or comments.") | ||
| else: | ||
| code_diff.append(diff_obj.a_path) |
There was a problem hiding this comment.
copied from
transformers/utils/tests_fetcher.py
Line 165 in c2589a8
amyeroberts
approved these changes
May 12, 2023
ydshieh
force-pushed
the
only_modified_doc_block
branch
from
c2589a8 to
0dd48c7
Compare
sheonhan
pushed a commit
to sheonhan/transformers
that referenced
this pull request
May 15, 2023
* min. version for pytest * fix * fix --------- Co-authored-by: ydshieh <[email protected]>
This was referenced May 15, 2023
gojiteji
pushed a commit
to gojiteji/transformers
that referenced
this pull request
Jun 5, 2023
* min. version for pytest * fix * fix --------- Co-authored-by: ydshieh <[email protected]>
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
* min. version for pytest * fix * fix --------- Co-authored-by: ydshieh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add files for doctesting only when they have modifications outside docstrings.
(offline message from Sylvain)