Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing torch version parsing. #143

Merged
merged 2 commits into from
Dec 29, 2022
Merged

Fixing torch version parsing. #143

merged 2 commits into from
Dec 29, 2022

Conversation

Narsil
Copy link
Collaborator

@Narsil Narsil commented Dec 28, 2022 •
edited
Loading

Fixes #142

When compiling from source, torch version can be more complex and include 0a0 for alpha versions. so we need to parse this better

@Narsil Narsil requested review from McPatate and sgugger December 28, 2022 09:50
@JasonGiedymin
Copy link

I'm working on a torch version for rocm (AMD) and got bit by this. Versions used by that team look like X.Y.Z+rocm5.2. Even if following semver, patch should be lenient.

sgugger
sgugger approved these changes Dec 29, 2022
View reviewed changes
Copy link
Contributor

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@Narsil Narsil merged commit 6cd64c7 into main Dec 29, 2022
@Narsil Narsil deleted the fix_torch_version_parsing_alpha branch December 29, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

@McPatate McPatate Awaiting requested review from McPatate

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version parsing fails on pytorch alpha
3 participants
@Narsil @JasonGiedymin @sgugger