-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version parsing fails on pytorch alpha #142
Comments
Fixed by hacking the file `version` in PyTorch.
On Tue, Dec 27, 2022 at 12:49 PM Kevin Turner ***@***.***> wrote:
Pytorch may reportedly have a version string like 2.0.0a0+gitd1123c9 when
compiled from source. That makes the safetensors Version parser fails with Python
patch version not an integer
https://github.com/huggingface/safetensors/blob/ba8de5ff52eee70e6bbc7e7c49a86c251da357d7/bindings/python/src/lib.rs#L463-L465
Reported by @lstein <https://github.com/lstein>.
—
Reply to this email directly, view it on GitHub
<#142>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA3EVN2TEPI3OAVCRAFK33WPMT3DANCNFSM6AAAAAATKTKBCE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Written on my cell phone. Anything that seems odd is the fault of
auto-correct.
|
Ok, thanks for the clarification !. And in case the version cannot be parsed we can adopt a default behavior instead of crashing. Thanks for the tip ! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Pytorch may reportedly have a version string like
2.0.0a0+gitd1123c9
when compiled from source. That makes the safetensors Version parser fail withPython patch version not an integer
safetensors/bindings/python/src/lib.rs
Lines 463 to 465 in ba8de5f
Reported by @lstein.
The text was updated successfully, but these errors were encountered: