gguf: Add type definitions for split.* metadata + sanity check
#679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add correct type definitions for GGUF
split.*, and use them inggufAllShardsfor sanity checks.The sanity checks does not really serves real-life purpose, since it is very unlikely that users mess up with file name. For now, it mostly to demonstrate how to use these metadata keys.
This PR also modify output format of
ggufAllShards. Because metadata is saved in the first split only, we can simply discard metadata of other splits.For more details, please have a look on
gguf-splitsource code:https://github.com/ggerganov/llama.cpp/blob/24ecb58168dce81646c2ed425690a106591c8c6d/examples/gguf-split/gguf-split.cpp#L223-L225