gguf.md: add sharding to naming convention #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofosyne
force-pushed
the
820-add-shard-to-naming-convention
branch
2 times, most recently
from
68fcf99 to
5f75cab
Compare
mishig25
reviewed
May 17, 2024
mishig25
reviewed
May 17, 2024
mofosyne
force-pushed
the
820-add-shard-to-naming-convention
branch
from
5f75cab to
c0f25bf
Compare
…expert count [no ci]
mofosyne
force-pushed
the
820-add-shard-to-naming-convention
branch
from
1fd0058 to
0b3cbe4
Compare
|
Minor commit to address Justine's observation that
So recommended that the model, version and expert count be derived from gguf metadata. This consistency should hopefully reduce surprises when creating upload scripts by making the filename generation a bit more repeatable. |
|
@ggerganov ready to merge |
mofosyne
force-pushed
the
820-add-shard-to-naming-convention
branch
from
1ef8674 to
25d5656
Compare
|
Still ready for review @ggerganov , just added a regex example and tighten up the description. |
ggerganov
approved these changes
May 19, 2024
|
@mishig25 it's now merged in, so you can use it now :) |
|
@mofosyne Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #822 (review) suggestion, adding support for sharding in naming convention.
Was a bit worried about if
-of-is going to be annoying to parse, but I think it's not too much to ask programmers to check ifXXXXX-of-XXXXXexist first and delete that before processing the rest from right to left by splitting by-. The requirement for 5 digits and-of-is pretty distinctive anyway.@ggerganov this is a PR to add this idea on behalf of @mishig25 and based on checking hf it appears to be a common enough convention already e.g. vicuna.gguf