Fix sagemaker config #2753
Merged
Fix sagemaker config #2753
+17
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Will be safe to merge after the user can verify :) ) |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Puts enable_cpu_affinity down a level so sagemaker can work.
Not quite sure what that means, but if the user can confirm that this fixes the issue, it should be good. However, it looks like the new test is failing because it requires sagemaker to be installed, can you verify?
|
@BenjaminBossan updated. Will also re-look at the test to make sure it doesn't need to be ran per-se, just check for config validity |
muellerzr
requested review from
BenjaminBossan
and removed request for
BenjaminBossan
BenjaminBossan
approved these changes
May 10, 2024
muellerzr
added a commit
that referenced
this pull request
May 10, 2024
* Fix sagemaker * Default to False * Include fixes * Nit * Ignore launching
muellerzr
added a commit
that referenced
this pull request
May 10, 2024
* Fix sagemaker * Default to False * Include fixes * Nit * Ignore launching
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Puts
enable_cpu_affinityinto theSagemakerConfigandwrite_basic_config(Similar to debug)We already have checks to verify if we should call cpu_affinity, so its safe to do (and will default to
Falseif they didn't pass it in), so even if sagemaker doesn't support it it will still (almost always) beFalseFixes #2744
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@BenjaminBossan