Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a few Sagemaker config issues #2732

Closed
wants to merge 4 commits into from

Conversation

nroggendorff
Copy link

@nroggendorff nroggendorff commented May 1, 2024

Updates config_args.py to work with the latest version of amazon sagemaker

In this new version, you are required to run variables operations with True or False, like --do_eval True as apposed to just --do_eval

@nroggendorff
Copy link
Author

wdym 0 tests passed

@BenjaminBossan
Copy link
Member

is_local_machine = yaml.safe_load(f).get("compute_environment", ComputeEnvironment.LOCAL_MACHINE) == ComputeEnvironment.LOCAL_MACHINE

https://github.com/huggingface/accelerate/pull/2732/files#diff-a9f583abbef3c8f66fac00f7194fd0c4ff7e8744e6b5aea39bf61342984e3887R28

f is undefined, which is why the tests are failing.

@nroggendorff
Copy link
Author

is_local_machine = yaml.safe_load(f).get("compute_environment", ComputeEnvironment.LOCAL_MACHINE) == ComputeEnvironment.LOCAL_MACHINE

https://github.com/huggingface/accelerate/pull/2732/files#diff-a9f583abbef3c8f66fac00f7194fd0c4ff7e8744e6b5aea39bf61342984e3887R28

f is undefined, which is why the tests are failing.

I see

@nroggendorff
Copy link
Author

stupid mistake

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@nroggendorff
Copy link
Author

well, Idk what to do

@BenjaminBossan
Copy link
Member

You're trying to use is_local_machine inside of from_yaml_file, where it's not defined, resulting in an error.

Generally, when CI fails, you can click on "Details" and check the failing tests there, this should give you an indication of what went wrong.

Copy link

github-actions bot commented Jun 1, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot closed this Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants