-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jpuerto/nihdev 454 ivt adjust dir schema validation for shared uploads #1290
Jpuerto/nihdev 454 ivt adjust dir schema validation for shared uploads #1290
Conversation
…idation-tools into jpuerto/NIHDEV-454-IVT-Adjust-dir-schema-validation-for-shared-uploads # Conflicts: # CHANGELOG.md
Two example uploads in DEV that passed metadata/directory schema validation (fail on plugins because the files are empty). |
Leaving this open for now as it requires some input from Stephen Fisher |
Unless uploads with shared directories will be passed "global" and "non_global" as part of the Upload's
One way of solving this would be to add to self.upload_ignore_globs if self.shared_directories is True, e.g.:
I added this inside |
@gesinaphillips - we should be fine here, the ingest-pipeline invocation basically ignores all directories at the top-level (which is why |
… actual stored values anywhere.
…idation-tools into jpuerto/NIHDEV-454-IVT-Adjust-dir-schema-validation-for-shared-uploads # Conflicts: # src/ingest_validation_tools/directory_validator.py # src/ingest_validation_tools/plugin_validator.py # src/ingest_validation_tools/validation_utils.py
…idation-tools into jpuerto/NIHDEV-454-IVT-Adjust-dir-schema-validation-for-shared-uploads # Conflicts: # CHANGELOG.md # examples/dataset-examples/bad-cedar-multi-assay-visium-with-standalone-histology-bad-dir-schema/MOCK_RESPONSE.json # examples/dataset-examples/good-cedar-multi-assay-visium-with-standalone-histology/MOCK_RESPONSE.json # src/ingest_validation_tools/upload.py
…idation-tools into jpuerto/NIHDEV-454-IVT-Adjust-dir-schema-validation-for-shared-uploads # Conflicts: # CHANGELOG.md # src/ingest_validation_tools/plugin_validator.py # src/ingest_validation_tools/upload.py
This PR adds support for the
global
andnon_global
shared uploads defined here: https://docs.google.com/document/d/1n2McSs9geA9Eli4QWQaB3c9R3wo5d5U1Xd57DWQfN5QThis PR also adds an example shared PhenoCycler dataset for automated testing.