Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent data_paths that are unique to a component dataset in multi-assay upload #1297

Merged
merged 9 commits into from
Feb 6, 2024

Conversation

gesinaphillips
Copy link
Collaborator

@gesinaphillips gesinaphillips commented Feb 6, 2024

A prior spec allowed for a multi-assay upload where one or more component dataset metadata.tsvs could have unique data_path values, indicating that in addition to the multi-assay upload there were one or more standalone datasets of a component type. I.e., the following was permissible:

upload/
     parent-metadata.tsv
     component1-metadata.tsv
     component2-metadata.tsv
     path-referenced-by-all/
     path-referenced-just-by-component2/

This pattern is now invalid.

Note: examples updated means large number of files changed. All substantive changes are in upload.py.

@gesinaphillips gesinaphillips marked this pull request as draft February 6, 2024 16:47
@gesinaphillips gesinaphillips marked this pull request as ready for review February 6, 2024 18:03
@gesinaphillips gesinaphillips merged commit 989031a into main Feb 6, 2024
8 checks passed
@gesinaphillips gesinaphillips deleted the phillips/prevent_multiple_assay_types branch February 6, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants