Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mccalluc/trivial example #1

Merged
merged 4 commits into from
Jan 9, 2020
Merged

Mccalluc/trivial example #1

merged 4 commits into from
Jan 9, 2020

Conversation

mccalluc
Copy link
Contributor

Trivial CWL that just lists outputs, plus test machinery for travis: I'd suggest that all the directories have the same naming convention and organization to keep things simple.

  • Does this pattern seem ok to you?
  • If I wanted something like this to actually be run, would I just tell you, either in the PR, or Slack?
  • There are different kinds of processing... On submission from users, or on completion of an earlier workflow; For every kind of file set, or just for particular file types: Do we know yet how those kind of conditions would be expressed?

@mccalluc mccalluc requested a review from pdblood December 11, 2019 21:23
@mccalluc mccalluc added the NEXT label Dec 13, 2019
@mccalluc
Copy link
Contributor Author

mccalluc commented Jan 7, 2020

@pdblood : Anything I can do to move this along?

Copy link
Member

@pdblood pdblood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll be refining and debugging the best practices for adding workflows and getting them running, but let's try this out and see how it goes.

@pdblood
Copy link
Member

pdblood commented Jan 9, 2020

Trivial CWL that just lists outputs, plus test machinery for travis: I'd suggest that all the directories have the same naming convention and organization to keep things simple.

* Does this pattern seem ok to you?

* If I wanted something like this to actually be run, would I just tell you, either in the PR, or Slack?

* There are different kinds of processing... On submission from users, or on completion of an earlier workflow; For every kind of file set, or just for particular file types: Do we know yet how those kind of conditions would be expressed?

Matt Rufflalo created the Airflow Python DAG to run his CWL workflow (based on existing DAGs in the repo) and submitted a pull request for that DAG. We can also create a DAG based on a workflow, but frankly we still need to sort out what the best practices should be. We'll start with internal developers and then consider how to support workflows submitted by external users.

A mechanism I'd like to try is for CWL workflows to be published in Dockstore and then pulled from Dockstore in the Airflow python DAG.

@pdblood pdblood merged commit 0ea58a9 into master Jan 9, 2020
@mccalluc mccalluc deleted the mccalluc/trivial-example branch January 9, 2020 19:54
@mccalluc mccalluc removed the NEXT label Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants