Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Team Discussions as GHDiscussion #839

Merged
merged 34 commits into from
Jun 8, 2020
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
af67eb7
feat: add new APi for Discussion
cmoulliard May 29, 2020
29aab9e
chore: Add missing classes and test case
cmoulliard May 29, 2020
9df5871
chore: wrapUp Github instance
cmoulliard May 29, 2020
dd7b471
fix: Add missing @throws IOException
cmoulliard May 29, 2020
d3a66f6
chore: Regenerate new testing files
cmoulliard May 29, 2020
56fe745
chore. Review test case. Add new wrapUp methods
cmoulliard Jun 4, 2020
6b80bb2
chore: Remove deleted resources files
cmoulliard Jun 4, 2020
343d623
chore: Push new resource files generated
cmoulliard Jun 4, 2020
3cacbc5
Fix: Set the organisation name to avoid to populate a url request hav…
cmoulliard Jun 4, 2020
6573f44
Fix: As the name of the organization could be empty/null, then use ge…
cmoulliard Jun 4, 2020
84c87ec
Chore: Fixed the null org within the generated json file but we still…
cmoulliard Jun 4, 2020
f0a3c26
Fix: Add the missing correct file to check the discussion created usi…
cmoulliard Jun 4, 2020
a88e9b2
Update src/main/java/org/kohsuke/github/GHDiscussion.java
cmoulliard Jun 4, 2020
2613ce0
Update src/main/java/org/kohsuke/github/GHDiscussion.java
cmoulliard Jun 4, 2020
5d09e6d
Update src/main/java/org/kohsuke/github/GHDiscussion.java
cmoulliard Jun 4, 2020
c116b60
Update src/main/java/org/kohsuke/github/GHDiscussion.java
cmoulliard Jun 4, 2020
c6ebf42
Update src/main/java/org/kohsuke/github/GHTeam.java
cmoulliard Jun 4, 2020
3190bde
Fix: Add mising try/catch block to report the exeption when no discus…
cmoulliard Jun 4, 2020
eca2f01
Fix: Add missing import statement for the Jackson Annotation. Use the…
cmoulliard Jun 4, 2020
ddf625c
Chore: Add method to delete a discussion using its number. Add field …
cmoulliard Jun 4, 2020
74db42a
Chore: Add method to update a discussion
cmoulliard Jun 4, 2020
b00a9fa
Fix: Add missing parameter
cmoulliard Jun 4, 2020
5a612e1
Chore: Add try/catch block if we cannot find the discussion to be upd…
cmoulliard Jun 4, 2020
d1952bf
Chore: Reformat method
cmoulliard Jun 4, 2020
73f07f1
Chore: Remove javadoc Throwing the exception
cmoulliard Jun 4, 2020
870090e
Chore: Remove javadoc Throwing the exception for the GHDiscussionbui…
cmoulliard Jun 4, 2020
947caff
Chore: Add method to get a discussion using a number/id
cmoulliard Jun 4, 2020
9484f8e
Chore: Add more methods to test CRUD operations on discusions
cmoulliard Jun 4, 2020
e5ed521
Fix: Add missing @param for the delete() method
cmoulliard Jun 4, 2020
beca544
Merge branch 'master' into issue-828
cmoulliard Jun 8, 2020
086425d
Tweaks for batch update
bitwiseman Jun 5, 2020
1ad701f
Add convenience override of getId()
bitwiseman Jun 8, 2020
927d279
Move url construction to single method
bitwiseman Jun 8, 2020
fde48e6
Test coverage and javadoc fixes
bitwiseman Jun 8, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/main/java/org/kohsuke/github/GHTeam.java
Original file line number Diff line number Diff line change
@@ -336,8 +336,6 @@ public GHDiscussionBuilder createDiscussion(String name) throws IOException {
*
* @param number
* the number
* @throws IOException
* the io exception
*/
public void deleteDiscussion(String number) {
try {