Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Team Discussions as GHDiscussion #839

Merged
merged 34 commits into from
Jun 8, 2020

Conversation

bitwiseman
Copy link
Member

@bitwiseman bitwiseman commented Jun 8, 2020

Description

Replaces #834

Add new API for discussion : https://developer.github.com/v3/teams/discussions/#create-a-discussion

Fixes #828

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than master. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn clean compile locally. This may reformat your code, commit those changes.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

cmoulliard and others added 30 commits May 29, 2020 16:28
Change the visibility of the fields from protected to private. Add @JacksonInject annotation. Rename html_url to htmlUrl as needed by Jackson

Co-authored-by: Liam Newman <[email protected]>
Remove to set the field `root`

Co-authored-by: Liam Newman <[email protected]>
Remove `this.root` as it is already set with the org

Co-authored-by: Liam Newman <[email protected]>
Add doc link to github team discussion API

Co-authored-by: Liam Newman <[email protected]>
Dont wrapUp using the team object

Co-authored-by: Liam Newman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Github Discussions API
2 participants