Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MANNEQUIN to GHCommentAuthorAssociation enum #1753

Merged
merged 4 commits into from
Nov 24, 2023
Merged

Add MANNEQUIN to GHCommentAuthorAssociation enum #1753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d3b55c3
Add MANNEQUIN value to GHCommentAuthorAssociation enum
choichanhyeok Nov 23, 2023
8777480
Update EnumTest for GHCommentAuthorAssociation with MANNEQUIN
choichanhyeok Nov 23, 2023
a454ef7
Update GHCommentAuthorAssociation.java
bitwiseman Nov 23, 2023
b7a4574
Update GHCommentAuthorAssociation.java
bitwiseman Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/org/kohsuke/github/GHCommentAuthorAssociation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ public enum GHCommentAuthorAssociation {
* Author has not previously committed to the repository.
*/
FIRST_TIME_CONTRIBUTOR,
/**
* Author is a placeholder for an unclaimed user.
*/
MANNEQUIN,
Copy link
Contributor Author

@choichanhyeok choichanhyeok Nov 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bitwiseman,

I wanted to express my gratitude for your review of my PR and for the adjustment you made to the 'MANNEQUIN' field. It was a detail I overlooked, and your your helpful modification not only corrected it but also improved the overall quality of the code. Your guidance and attention to detail are greatly appreciated.

This experience has been a valuable lesson for me in terms of attention to detail and has motivated me to be more thorough in my future contributions.

Thank you again for your support and for maintaining such a high standard in the project.

/**
* Author is a member of the organization that owns the repository.
*/
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/kohsuke/github/EnumTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public void touchEnums() {
assertThat(GHCheckRun.Conclusion.values().length, equalTo(9));
assertThat(GHCheckRun.Status.values().length, equalTo(4));

assertThat(GHCommentAuthorAssociation.values().length, equalTo(7));
assertThat(GHCommentAuthorAssociation.values().length, equalTo(8));

assertThat(GHCommitState.values().length, equalTo(4));

Expand Down