Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MANNEQUIN to GHCommentAuthorAssociation enum #1753

Merged
merged 4 commits into from
Nov 24, 2023

Conversation

choichanhyeok
Copy link
Contributor

@choichanhyeok choichanhyeok commented Nov 23, 2023

Description

This PR introduces the MANNEQUIN value to the GHCommentAuthorAssociation enum. This change is necessary to handle the unclaimed user scenario, particularly in migrated repositories where the user's association with the repository is not defined.

This fixes #1716.

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments explaining the behavior.
  • When adding or updating methods that fetch entities, add @link JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

This commit updates the EnumTest to reflect the addition of the MANNEQUIN value in the GHCommentAuthorAssociation enum. The test now checks for the correct number of enum values, which has been increased to 8 to include MANNEQUIN.
@choichanhyeok choichanhyeok changed the title Add mannequin enum Add MANNEQUIN to GHCommentAuthorAssociation enum Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (40992f7) 80.16% compared to head (b7a4574) 80.41%.
Report is 17 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1753      +/-   ##
============================================
+ Coverage     80.16%   80.41%   +0.25%     
- Complexity     2301     2309       +8     
============================================
  Files           217      218       +1     
  Lines          6962     7016      +54     
  Branches        371      371              
============================================
+ Hits           5581     5642      +61     
+ Misses         1150     1141       -9     
- Partials        231      233       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -26,7 +26,8 @@ public enum GHCommentAuthorAssociation {
/**
* Author is a placeholder for an unclaimed user.
*/
MANNEQUIN, /**
MANNEQUIN,
Copy link
Contributor Author

@choichanhyeok choichanhyeok Nov 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bitwiseman,

I wanted to express my gratitude for your review of my PR and for the adjustment you made to the 'MANNEQUIN' field. It was a detail I overlooked, and your your helpful modification not only corrected it but also improved the overall quality of the code. Your guidance and attention to detail are greatly appreciated.

This experience has been a valuable lesson for me in terms of attention to detail and has motivated me to be more thorough in my future contributions.

Thank you again for your support and for maintaining such a high standard in the project.

@bitwiseman bitwiseman merged commit 788e186 into hub4j:main Nov 24, 2023
11 checks passed
@bitwiseman
Copy link
Member

Thanks for contributing this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GHCommentAuthorAssociation MANNEQUIN missing
2 participants