-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MANNEQUIN to GHCommentAuthorAssociation enum #1753
Conversation
This commit updates the EnumTest to reflect the addition of the MANNEQUIN value in the GHCommentAuthorAssociation enum. The test now checks for the correct number of enum values, which has been increased to 8 to include MANNEQUIN.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1753 +/- ##
============================================
+ Coverage 80.16% 80.41% +0.25%
- Complexity 2301 2309 +8
============================================
Files 217 218 +1
Lines 6962 7016 +54
Branches 371 371
============================================
+ Hits 5581 5642 +61
+ Misses 1150 1141 -9
- Partials 231 233 +2 ☔ View full report in Codecov by Sentry. |
@@ -26,7 +26,8 @@ public enum GHCommentAuthorAssociation { | |||
/** | |||
* Author is a placeholder for an unclaimed user. | |||
*/ | |||
MANNEQUIN, /** | |||
MANNEQUIN, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @bitwiseman,
I wanted to express my gratitude for your review of my PR and for the adjustment you made to the 'MANNEQUIN' field. It was a detail I overlooked, and your your helpful modification not only corrected it but also improved the overall quality of the code. Your guidance and attention to detail are greatly appreciated.
This experience has been a valuable lesson for me in terms of attention to detail and has motivated me to be more thorough in my future contributions.
Thank you again for your support and for maintaining such a high standard in the project.
Thanks for contributing this PR! |
Description
This PR introduces the MANNEQUIN value to the GHCommentAuthorAssociation enum. This change is necessary to handle the unclaimed user scenario, particularly in migrated repositories where the user's association with the repository is not defined.
This fixes #1716.
Before submitting a PR:
@link
JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install site
locally. If this command doesn't succeed, your change will not pass CI.main
. You will create your PR from that branch.When creating a PR: