Generate save state IDs for homebrew #7997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I don't understand...
|
|
Really? Weird. Worked for me, let me test some more... Yeah, there's definitely a problem. I'll fix it. |
|
@vnctdj thanks for testing, fixed it now I think :) |
|
I confirm the fix, it should be ok for merging now :) |
|
Looks like the UI.vcxproj ended up in here. -[Unknown] |
|
@unknownbrackets |
hrydgard
force-pushed
the
homebrew-savestate
branch
from
8d60c1f to
c5d745a
Compare
…where applicable.
hrydgard
force-pushed
the
homebrew-savestate
branch
from
c5d745a to
8996f58
Compare
hrydgard
added a commit
that referenced
this pull request
Sep 25, 2015
Generate save state IDs for homebrew
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now they won't all save to the same state.
Fixes #7795 .
If you load a loose elf file, the savegame will be the name of the elf. So cube.elf will have save ID "cube".
If you load a PBP from a PSP/GAME folder like cave story, it'll take the last part of the path. So PSP/GAME/cavestory will have save ID "cavestory".
I think this is good enough, although of course two users could name their game folders differently, but that's their problem then :)