Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand #7997 (save states files naming) to cheat files #8023

Closed
pal1000 opened this issue Oct 4, 2015 · 3 comments · Fixed by #8818
Closed

Expand #7997 (save states files naming) to cheat files #8023

pal1000 opened this issue Oct 4, 2015 · 3 comments · Fixed by #8818
Labels

Comments

@pal1000
Copy link
Contributor

pal1000 commented Oct 4, 2015

I know this came at a really bad time, right after release. To be honest I didn't expect it to be today.
But without this #7997 looks like only half done and is a missed opportunity.

@hrydgard
Copy link
Owner

hrydgard commented Oct 4, 2015

Yes, good point. The whole "game id" logic needs cleaning up.

There's always 1.2, and I'm hoping to release that a bit faster...

@unknownbrackets
Copy link
Collaborator

Heh, famous last words.

Are there any other things which use the game id? There's the "fixes" and I think the savedata manageement (but the latter is a mostly lost cause with homebrew), and the title and UI.

We should probably have the logic in GenerateSaveSlotFilename moved to the gameinfo cache, and have that be one of the things it's responsible for - resolving the game id? Then we just need "current gameinfo" somehow?

-[Unknown]

@hrydgard
Copy link
Owner

hrydgard commented Oct 4, 2015

Yes, exactly my plan :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants