Force positions to scale by 128/32768 as the psp does #6737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes everything use floats for positions. On some hardware/drivers, this may be faster. On some it may be slower. We'll need testing to see the performance impact. Fixes Final Fantasy 4's pos misalignments, and probably others (like Tekken 5 I suspect.)
|
Nice. Merging after 0.9.9.1 tonight. |
It's pretty much all done the same way. Note that normals have always been a little inconsistent between 127/128 and 32767/32768. But it's probably not causing a major impact...
hrydgard
added a commit
that referenced
this pull request
Aug 19, 2014
Force positions to scale by 128/32768 as the psp does
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haven't measured the performance impact carefully on mobile, but I'm hoping it's small.
Fixes #1963, fixes #4617, fixes #2077, and reportedly fixes glitches in other games too.
Note that normals were and still are converted using varying methods currently: software uses 127/32767, hardware may use 127.5/32767.5 or 128/32768 depending on skin/morph. However, position should with these changes be the same everywhere.
Does not round positions correctly, which may or may not be important, but this gets us closer to accurate anyway in a way that definitely fixes some issues.
-[Unknown]