Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not matching/weird texture and geometry placement/allignment on SW/HW #1963

Closed
VIRGINKLM opened this issue May 28, 2013 · 19 comments · Fixed by #6737
Closed

Not matching/weird texture and geometry placement/allignment on SW/HW #1963

VIRGINKLM opened this issue May 28, 2013 · 19 comments · Fixed by #6737

Comments

@VIRGINKLM
Copy link
Contributor

I was a bit reluctant on starting up this issue but even though it's a slight difference or big areas or bigger resolution than native it can make a huge difference or make stuff look a bit deformed and it seems to affect more or less all games. So it seems that textures on Hardware transform are noticably placed a bit off compared to SW (software is the correct) which if I'm not wrong it didn't always happen. It looks like some values get rounded very sloppily resulting into textures being a couple of pixels shifted from where they should be and some geometry being a bit off. (faces in Kingdom Hearts appear like the eyes are a bit distant/derp-face-like and the point of the texture that gets mirrored is very obvious. Kinda the same with FF T-0 but the models on the huge ares like around the fountain, changing from SW/HW makes them look like they move their hands/legs/heads when they should be stationary)

You need to fast swap between them to notice so put them on fullscreen.
HW - Textures are off (notice the gap in the door)
ppssppwindows 2013-05-28 11-42-57-31
SW - Correct placing of textures
ppssppwindows 2013-05-28 11-43-03-46
HW - Geometry seems a bit off, heads, legs, placement on the ground, bushes etc
ppssppwindows 2013-05-28 11-43-29-84
SW - Correct geometry
ppssppwindows 2013-05-28 11-43-31-29

@hrydgard
Copy link
Owner

I know what the problem with the textures is, I just figured it wasn't very noticable but it seems I'm wrong (although it's a bit hard to see the difference without flipping between these pictures). I'm gonna fix it tonight.

As for the geometry differences, I thought I had sorted that out but it seems not. will look into it.

@solarmystic
Copy link
Contributor

Afaik, there quite a number of games related to this issue and HW Transform's inaccuracy regarding placement/positioning of geometry and textures

Final Fantasy IV is one example (as per this ppsspp.org forum post by Nezarn)

http://forums.ppsspp.org/showthread.php?tid=1971&pid=24357#pid24357

Tekken 5 is another (game needs HW Transform OFF to display UI texture elements like the remaining health bar correctly)

@hrydgard
Copy link
Owner

Okay, thanks. Will fix.

@VIRGINKLM
Copy link
Contributor Author

@hrydgard Thanx, sorry to come up with an issue for it, but I wanted to make sure it wasn't my imagination and I wanted to be sure that it was known and it can/cannot get fixed. It actually gets noticable even on 1x on stuff like the facial textures on KHBBS and stuff that should attach and they don't like doors.

@hrydgard
Copy link
Owner

No need to be sorry, this is definitely a real issue then.

@bsauvage1
Copy link

Same issue as later part of #1855
-> still quite noticeable in GoW for example (see the picture there), but good to hear it will be fixed!

@hrydgard
Copy link
Owner

Those cracks in Kratos head there is probably not quite the same issue as it only seems to happen on iOS?

@hrydgard hrydgard reopened this May 30, 2013
@hrydgard
Copy link
Owner

Reopened because that probably just fixes the texture coordinate issue, not the misplaced geometry one.

@VIRGINKLM
Copy link
Contributor Author

Atleast half of the issue is done now. I guess it must be really tough to debug that.

@VIRGINKLM
Copy link
Contributor Author

Have you found what's causing the geometry bug? I found that it may affect games that are rhythm based on too (the object that tells you when to push accurately a button is not displayed on exactly the right place so you may miss in timing). I hate when accurate emulation is mandatory.

@unknownbrackets
Copy link
Collaborator

Sounds like this is likely similar to the FF4/FF3 alignment issues in 2D (#4617.)

-[Unknown]

@VIRGINKLM
Copy link
Contributor Author

It's not game specific what I posted here, FFT-0 was an example I could capture the change to be really obvious.

@unknownbrackets
Copy link
Collaborator

Is any of this improved by these changes?

https://github.com/unknownbrackets/ppsspp/compare/pos-scale

-[Unknown]

@daniel229
Copy link
Collaborator

Issue is fixed with those changes.

@unknownbrackets
Copy link
Collaborator

Neato. Thanks for checking.

Patapon 2 has a glitch in its textboxes that isn't, unfortunately, but it doesn't work in hw or sw and I'm pretty sure it's a different issue.

-[Unknown]

@daniel229
Copy link
Collaborator

flicker fixed
Jak and Daxter
killzone
Indiana Jones and the Staff og Kings

improved
Assassin's Creed Bloodlines (require vertex cache off)

Not fixed
Ikki Tousen: Xross Impact (require vertex cache off)
#6485 (only works with softGPU)
#6066 (require vertex cache off)

@unknownbrackets
Copy link
Collaborator

Note that this will not possibly improve bugs caused by the vertex cache (like #6066.)

-[Unknown]

@daniel229
Copy link
Collaborator

Assassin's Creed Bloodlines
killzone
Indiana Jones and the Staff og Kings
Those games require vertex cache off and still get improvement.

@VIRGINKLM
Copy link
Contributor Author

I guess this indeed fixes the issue, well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants