Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative framebuffer approach #5679

Closed
wants to merge 1 commit into from
Closed

Alternative framebuffer approach #5679

wants to merge 1 commit into from

Conversation

dbz400
Copy link
Contributor

@dbz400 dbz400 commented Mar 18, 2014

This alternative framebuffer approach basically fixes all the following issues probably more however it only broken kingdom heart but no others.Probably we can do it as option ? i'm not sure.

Fixes #5506
Fixes #4472
Fixes #4325
Fixes #4112
(partial due to stencil uniform value)

@DonelBueno
Copy link

This looks very promissing.

It would be great if @solarmystic could test this changes in his games library.

@thedax
Copy link
Collaborator

thedax commented Mar 18, 2014

@raven02: What about TOF? You said 3 months ago that it'd break with this change.

@solarmystic
Copy link
Contributor

@raven02 @DonelBueno
I'll perform the usual in depth testing with my test suite and report back later. It'll take a while though, I'm rather occupied at the moment. So if either @hrydgard or @unknownbrackets haven't shot down the approach by the time I'm finished, I'll definitely post the table.

I don't think this will be merged (if it passes peer review) until after 0.9.8 though, it's quite a radical change and @hrydgard is probably keeping the emulator in functional lockdown until after the official release is done.

Nice to see you haven't given up yet, @raven02, it's been quite sometime since your last framebuffer related commit.

:)

@solarmystic
Copy link
Contributor

@unknownbrackets @hrydgard @raven02

Test results for your perusal:-

capture

Major Observations:-

a. As @raven02 mentioned in his pull request, Kingdom Hearts BBS has malformed shadows cast by the PC and the enemies again in this test build.

uljm05775_00000

b. There is a minor regression in Final Fantasy II. The Square Enix logo that is part of the opening sequence now flickers. This is not present in the current master.

c. Ingame FMV playback in Valkyrie Profile Lenneth is misshapen and malformed in this test build. This is a major regression from the current master which has perfectly sized FMVs during playback.

ulus10107_00001

Current Master:-

ulus10107_00000

d. In addition, the graphical abnormality seen in the character portraits when Rendering Resolution is above 1x is also present even at 1x in the testbuild. The picture also looks fuzzier as compared to master:-

ulus10107_00000

Current Master:-

ulus10107_00001

Conclusion:-

While this commit satisfies most games in the list, some undergo a significant regression.

@dbz400
Copy link
Contributor Author

dbz400 commented Mar 19, 2014

Probably it would be good to be an option

(I'm wondering it is possible that hybrid can be done with softGPU and GLES )

@mckimiaklopa
Copy link

Hope this somehow improves power vr

@dbz400 dbz400 closed this Mar 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants