Outrun 2006 Lighting Bug: Every cars' colours are wrong

[thedax]

As a continuation of #2603, it makes more sense to begin parsing out the game's remaining separate issues into their own issues instead of one mega issue for everything wrong.

In this particular instance, nearly all of the cars in the game have the wrong colours.

Screenshots of all of the cars (in their default colours) from RHW: http://min.us/mbwKK55M1pdsCm

Screenshots of all of the cars (in their default colours) from PPSSPP: http://min.us/mbqcmIXrarTMEs

I'm currently unaware if they've ever been correct. I need to investigate. From a few screenshots I've seen of the game in JPCSP, the car colours appear to be correct.

[thedax]

This is interesting: PPSSPP actually renders the colours right, but then some sort of reflection or something gets put on top of it, and that's when it looks incorrect:

Don't mind the debug info on this first screen, the point of it is to illustrate the correct colour:

Here's the "reflection" or whatever it's doing to the car afterward:

[unknownbrackets]

What happens if you disable lighting when it's drawing the reflection? You might have to keep disabling it. Just double click Lighting under Flags until it's 0.

-[Unknown]

[dbz400]

If i remember correctly , set the vfb->format == fmt , fixes the color issue here but breaks Kingdom Heart.

     if (MaskedEqual(v->fb_address, fb_address) && vfb->format == fmt) 

[thedax]

@unknownbrackets: When lighting is disabled, the car is drawn correctly, but without the "shininess", of course:

For comparison, here's the bug:

[unknownbrackets]

It'd be great to see all the values from the Lighting tab.

-[Unknown]

[thedax]

When it's first drawn as yellow (no reflection yet):
Ambient color 000000
Ambient alpha 0000ff
Material update ambient, diffuse, specular
Material emissive 000000
Material ambient 8b8b8b
Material diffuse 7f7f7f
Material alpha 0000ff
Material specular 8b8b8b
Mat. specular coef 0.500000
Reverse normals 0
Shade model 1
Light mode 0
Light type 0 1
Light type 1 0 (disabled)
Light type 2 0 (disabled)
Light type 3 0 (disabled)
Light pos 0 -0.500000, -0.707092, -0.499992
Light pos 1 -1.000000, -0.000000, -0.000000 (disabled)
Light pos 2 -0.000000, -0.190807, -0.981613 (disabled)
Light pos 3 0.000000, 0.000000, 0.000000 (disabled)
Light dir 0 0.000000, 0.000000, 0.000000
Light dir 1 0.000000, 0.000000, 0.000000 (disabled)
Light dir 2 0.000000, 0.000000, 0.000000 (disabled)
Light dir 3 0.000000, 0.000000, 0.000000 (disabled)
Light att 0 0.000000, 0.000000, 0.000000
Light att 1 0.000000, 0.000000, 0.000000 (disabled)
Light att 2 0.000000, 0.000000, 0.000000 (disabled)
Light att 3 0.000000, 0.000000, 0.000000 (disabled)
Lightspot coef 0 0.000000
Lightspot coef 1 0.000000 (disabled)
Lightspot coef 2 0.000000 (disabled)
Lightspot coef 3 0.000000 (disabled)
Light angle 0 0.000000
Light angle 1 0.000000 (disabled)
Light angle 2 0.000000 (disabled)
Light angle 3 0.000000 (disabled)
Light ambient 0 3f3f3f
Light diffuse 0 9f9f9f
Light specular 0 000000
Light ambient 1 000000 (disabled)
Light diffuse 1 000000 (disabled)
Light specular 1 000000 (disabled)
Light ambient 2 000000 (disabled)
Light diffuse 2 000000 (disabled)
Light specular 2 000000 (disabled)
Light ambient 3 000000 (disabled)
Light diffuse 3 000000 (disabled)
Light specular 3 000000 (disabled)

When the car has the reflection drawn on it:
Ambient color 000000
Ambient alpha 0000ff
Material update none
Material emissive ffffff
Material ambient 000000
Material diffuse 000000
Material alpha 0000ff
Material specular 000000
Mat. specular coef 0.500000
Reverse normals 0
Shade model 1
Light mode 0
Light type 0 1 (disabled)
Light type 1 0
Light type 2 0
Light type 3 0 (disabled)
Light pos 0 -0.500000, -0.707092, -0.499992 (disabled)
Light pos 1 -1.000000, -0.000000, -0.000000
Light pos 2 -0.000000, -0.190807, -0.981613
Light pos 3 0.000000, 0.000000, 0.000000 (disabled)
Light dir 0 0.000000, 0.000000, 0.000000 (disabled)
Light dir 1 0.000000, 0.000000, 0.000000
Light dir 2 0.000000, 0.000000, 0.000000
Light dir 3 0.000000, 0.000000, 0.000000 (disabled)
Light att 0 0.000000, 0.000000, 0.000000 (disabled)
Light att 1 0.000000, 0.000000, 0.000000
Light att 2 0.000000, 0.000000, 0.000000
Light att 3 0.000000, 0.000000, 0.000000 (disabled)
Lightspot coef 0 0.000000 (disabled)
Lightspot coef 1 0.000000
Lightspot coef 2 0.000000
Lightspot coef 3 0.000000 (disabled)
Light angle 0 0.000000 (disabled)
Light angle 1 0.000000
Light angle 2 0.000000
Light angle 3 0.000000 (disabled)
Light ambient 0 3f3f3f (disabled)
Light diffuse 0 9f9f9f (disabled)
Light specular 0 000000 (disabled)
Light ambient 1 000000
Light diffuse 1 000000
Light specular 1 000000
Light ambient 2 000000
Light diffuse 2 000000
Light specular 2 000000
Light ambient 3 000000 (disabled)
Light diffuse 3 000000 (disabled)
Light specular 3 000000 (disabled)

[thedax]

When the reflection is drawn:

Textures: https://gist.github.com/thedax/2ad0a7ed4c4500d2ba01/raw/ff75b703d8369a9e33f98cba07b54c8783612dc1/gistfile1.txt

Settings: https://gist.github.com/thedax/721f0f4898456907268c/raw/31169ec580764d3ed057cf25af9a67bf2d5a6063/gistfile1.txt

Vertices (raw box UNchecked): https://gist.github.com/thedax/fce4a59e888e49a784ac/raw/0ebaa5acbf62640715c0f68e2b6df91dab5fed3b/gistfile1.txt

Vertices (raw box checked): https://gist.github.com/thedax/e7baa5ff3be2f32f866f/raw/23db740bcd176e2c22dc88031c1e1a699a72c1fb/gistfile1.txt

Matrices: https://gist.github.com/thedax/88afd4d28cbf9c5c2f94/raw/056079be7e79760672930c7536d08c5969c07642/gistfile1.txt

Lists tab: Start PC PC Stall State Started Interrupted
0x08BF6540 0x08DFBD24 0x08BF86C8 Running Yes No

[hrydgard]

So it's obviously making the car shiny using an environment map, which might be dynamic. If we are rendering to that environment map, maybe that's when we have the wrong colors?

[thedax]

Is there a simple way to check for an amateur like me?

[dbz400]

if i try to shuffle 0.5 , it did show the yellow shinning .

        case GE_TEXMAP_ENVIRONMENT_MAP:  // Shade mapping - use dots from light sources.
            WRITE(p, "  v_texcoord = u_uvscaleoffset.xy * vec2(1.0 + dot(normalize(u_lightpos%i), worldnormal), 1.0 - dot(normalize(u_lightpos%i), worldnormal) * 0.5);\n", gstate.getUVLS0(), gstate.getUVLS1());
            break;

[dbz400]

In software rendering , if we remove the / 2.f , the shinning reappears as well

        if (gstate.getUVLS0() == (int)light)
            vertex.texturecoords.s() = (diffuse_factor + 1.f) ;

        if (gstate.getUVLS1() == (int)light)
            vertex.texturecoords.t() = (diffuse_factor + 1.f) ;

[ThePhoenixRises]

Would it be possible to add the game Dirt 2 (ULES01301) to this issue, as it has similar shading problems with the cars skins.
Buffered Rendering produces these:

[hrydgard]

Non-buffered rendering is irrelevant because it's a performance hack that skips all rendering to textures, so things like this will break. It's only interesting if it's broken with buffered rendering.

Which is seems to be given your two last images, so okay :)

[thedax]

Um..this wasn't fixed with that commit, it was just mostly corrected.

See #5612 (comment) for how it looks now.

[hrydgard]

Autoclosed, sorry.

[thedax]

Ah, right. I forgot Github does that. It's okay.

[thedax]

Quick update, this affects Direct3D9 as well, and the issue is still happening on the latest builds with both backends.

[thedax]

Yet another update: somewhere along the way, OpenGL lost the environment mapping on the cars, making them look dull and flatly shaded, while Direct3D9 continues to have shiny cars with the wrong colours. if you'd like me to bisect to find where OpenGL went astray, I can.

[thedax]

While I'm on the subject of updating some of my old issues, this one is still present, with one minor new piece of info: Vulkan suffers from the same missing environmental mapping as OpenGL (which is expected :) ). Direct3D9 still has shiny cars, but bad colours on small parts of the cars (e.g. where bumpers or chrome pieces are).

[ThePhoenixRises]

Same issue with Dirt 2 same problems with the skins of the cars showing incorrect colours.

[thedax]

Update on this with the latest commit ( 562c5f6 ): Cars are still missing their reflections/environment maps on all backends, but software rendering appears to display them correctly. However, as far as I can tell, the original issue of "every car has the wrong colours in Outrun 2006" has been fixed on all backends (on Windows), so I think it might be worth making a new issue for it and closing this one, so new info can be gathered; I'll let Unknown decide on that though.

Vulkan:

Software (Vulkan backend):

[unknownbrackets]

Interesting. I wonder when it improved - maybe whatever change fixed that could lead us to a reflection fix.

I am a fan of a new issue, to avoid getting lost on comments. But I don't think it's important either way. A GE debugger dump might help for the reflection issue.

Especially interesting: if you create the dump while on software, does it work on hardware? If yes, it's almost definitely a framebuffer effect or upload/download. If it still doesn't work, then it's some mishandled state.

-[Unknown]

[thedax]

From what i saw, yes, the dump made on software works on hardware. Here are two dumps I took, one on Vulkan (hardware) and one on Vulkan (software):

DUMP.zip

That being said though, let's move this over to a new issue.

[unknownbrackets]

Yeah, the texture is blank. It seems to use a 4444 texture using tex env mapping. I'm guessing it's an upload of some kind - I'm not sure where, though. It could be 0x040cc000.

-[Unknown]

[hrydgard]

Blank texture data in VRAM can of course also be caused by faulty render target downloads/writebacks... But let's add any further comments or research in the new issue instead.