Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cheat import: Allow picking a file to import from #17164

Merged
merged 5 commits into from
Mar 23, 2023
Merged

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Mar 23, 2023

Allows the user to pick a cheat.db file to import from, which is more intuitive than a fixed location on the memstick. Was super easy to implement now after the big refactoring I did yesterday - previously it was gonna be rough.

image

A very minimal upgrade to the UI. How cheats work really needs a complete overhaul (just look at those category headers, heh), but that won't happen for 1.15.

Fixes #16648

@hrydgard hrydgard added this to the v1.15.0 milestone Mar 23, 2023
@hrydgard hrydgard marked this pull request as ready for review March 23, 2023 12:48
@hrydgard hrydgard merged commit c791d64 into master Mar 23, 2023
@hrydgard hrydgard deleted the cheat-import-fix branch March 23, 2023 13:17
@unknownbrackets
Copy link
Collaborator

Well, the only ways to fix those headers is to recognize some patterns cheat authors often used (and hope you never match something they told people had to be turned on), or invent a brand new cheat file format / changes to the existing one. It's really a deficiency in still using cwcheat.

-[Unknown]

@hrydgard
Copy link
Owner Author

Current thoughts are around a new cheat format based on js, distributed via the homebrew store, the contents of which will live here on github so people can contribute (plus automatic conversion of old cheat databases to get the ecosystem started). Though, a tall order..

@LunaMoo
Copy link
Collaborator

LunaMoo commented Mar 26, 2023

@iota97 did some work on headers and descriptions:
https://github.com/iota97/ppsspp/tree/cheat-header

and it's definitely better to have new extensions and formats for emulator/ui specific features than detect patterns that some person or group of people decided to use in their cheat database as there will always be a person that uses such pattern without wanting his cheat to be turned into a header or description.

Also hope that no large cheat database will be held within official PPSSPP repo as most cheat databases are impossible to maintain and emulator-in-developement makes it even harder since most of those cheats need to be updated every other relevant improvement to emulation, things like that should be kept separate from main projects.

It probably shouldn't even be officially linked as people will spam here with all their issues caused by those cheats and they do have a lot of issues even when tested as nobody sits there playing with cheats from start to finish. Plus there's a ton of users that will request cheats for games that doesn't have any cheats or doesn't have that one particular cheat they wish it had that different game had.

Creating great UI for cheats might be very hard since every other person will have different demands for it. What we currently have is very close to original cwcheat experience, just go to menu with cheats and activate what we want, it works great for what it is and PSP games aren't that complex to really need more when it comes to cheating for what it was 20 years ago, but there will always be people coming from paid cheating software available for online PC games(cheating in online games is generally frowned upon in most cheating communities, but that's where the money is and with that comes new ideas that we later might be requested for offline games as well) that does much more, draw overlays on top of the game, custom UI elements or plain text on the screen, mod menus, built-in scripting language etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make cheat import UI clearer
3 participants