Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cheat import UI clearer #16648

Closed
hrydgard opened this issue Dec 23, 2022 · 1 comment · Fixed by #17164
Closed

Make cheat import UI clearer #16648

hrydgard opened this issue Dec 23, 2022 · 1 comment · Fixed by #17164
Labels
User Interface PPSSPP's own user interface / UX
Milestone

Comments

@hrydgard
Copy link
Owner

If you press "Import from Cheats.db" and no file is there, nothing happens.

It should probably tell the user where to put the file. Also, could be interesting to store cheat.db files on the homebrew store for easy automatic download - and maybe just automatically import cheats if a cheats.db file exists, when opening the cheats dialog for a game?

Also, the "Enable cheats" option should possibly be removed?

@hrydgard hrydgard added the User Interface PPSSPP's own user interface / UX label Dec 23, 2022
@hrydgard hrydgard added this to the v1.15.0 milestone Dec 23, 2022
@unknownbrackets
Copy link
Collaborator

By the way, some years ago when I changed the parsing of cwcheat files to build a "bytecode", I made it able to parse a cheat file with multiple games in it. I think it was necessary to "import from" such a file before, because the code would run ALL cheats, even unrelated to this game (there's some _G ULES-12345 headers.)

Maybe we could even just get rid of the "import" step? It would be like the PSP then, I think?

I think the option to enable/disable cheats were discussed in #8171. I will say it is common that it causes crashes/problems and many emulators have an easy on/off switch for cheats. If we remove it, we may end up with people wanting "cheat profiles" so they have a way to temporarily turn on those hacky cheats they use that only work when they are i.e. in a race.

-[Unknown]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Interface PPSSPP's own user interface / UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants