PPGe: Scale down by worst of window/internal res #13962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm. I'm of two minds whether it's right to involve the window resolution at all in this calculation. But should be OK. |
|
Well, ignoring it gives you this:
Instead of:
At 2x or higher it's small and probably hard to read, but at least it can be read:
We could just truncate everyone and refuse to make it smaller ever, but it's nice to be able to get to the extra detail. To be fair, probably a lot of people ignore this text anyway, and only a small percent of games seem to use these longer descriptions. -[Unknown] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a really low render resolution but a high window resolution, we were allowing more scale down than intended. Though, it still looked more readable for me than #13958.
This just takes the lowest of the two when considering how much to shrink text. This only happens when there's a lot of text, so most games will be unchanged.
-[Unknown]